Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1230321

Re: [PATCH] ARM: davinci: clock: Correct return values for API functions

From Sekhar Nori <nsekhar@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ARM: davinci: clock: Correct return values for API functions
Date 2015-09-22 17:30 +0200
Message-ID <qbxG2-P2-15@gated-at.bofh.it> (permalink)
References <q8yoZ-2gE-51@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Monday 14 September 2015 02:59 PM, Peter Ujfalusi wrote:
> Fix the values returned by the publicly used functions.
> These function should return 0 when they are called with clk == NULL in
> similar manner as the clock API does to avoid different behavior in drivers
> used by daVinci and other architectures.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> ---
> Hi Sekhar,
> 
> This issue is visible when using generic drivers like ASoC simnple card for
> audio support.
> They rely on the fact that these functions will not return with error in case
> of clk == NULL.

Looks good. Will queue for v4.4. Some of the information below the tear
line could go into the commit text too, I think.

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] ARM: davinci: clock: Correct return values for API functions Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-14 11:40 +0200
  Re: [PATCH] ARM: davinci: clock: Correct return values for API functions Sekhar Nori <nsekhar@ti.com> - 2015-09-22 17:30 +0200

csiph-web