Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1230175
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Andrzej Hajda <a.hajda@samsung.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Coccinelle: remove incorrect -include option transformation |
| Date | Tue, 22 Sep 2015 15:20:02 +0200 |
| Message-ID | <qbvEd-6p9-5@gated-at.bofh.it> (permalink) |
| References | <qbvbc-5BU-33@gated-at.bofh.it> <qbvkT-5Nf-39@gated-at.bofh.it> |
| X-Original-To | Julia Lawall <julia.lawall@lip6.fr> |
| X-Auditid | cbfec7f5-f794b6d000001495-b3-5601532b6bfc |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=windows-1252 |
| Content-Transfer-Encoding | 7bit |
| X-Brightmail-Tracker | H4sIAAAAAAAAA+NgFnrALMWRmVeSWpSXmKPExsVy+t/xa7rawYxhBj1buC02zljPavFj02o2 i9k/LzFZLHtwmtHi8q45bBZrj9xlt5jTOovN4tjL5UwOHB7HjrUye+zdkuXRt2UVo8f6LVdZ PB4tu8/i8XmTXABbFJdNSmpOZllqkb5dAlfGme+6BXt4K2b3LWBrYHzE1cXIySEhYCIx53YL C4QtJnHh3no2EFtIYCmjxNYX9V2MXED2c0aJwz/mMIIkhAUCJM6s7mPtYuTgEBFQl+j9kAtR XyRxatppNpB6ZoETTBKr5jUxgyTYBDQl/m6+CTaUV0BNYmvPMbBlLAKqEqenbGYCsUUFIiRO nX0LVSMo8WPyPRaQ+ZwClhIHJ8eCmMwCehL3L2qBVDALyEtsXvOWeQKjwCwkDbMQqmYhqVrA yLyKUTS1NLmgOCk910ivODG3uDQvXS85P3cTIyTcv+5gXHrM6hCjAAejEg+vRx9DmBBrYllx Ze4hRgkOZiUR3nWKjGFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeWfueh8iJJCeWJKanZpakFoE k2Xi4JRqYJw7ffJHbaWQrm0hQeYeD7Ysj1l2c3br1IfMNy/9Fv2Ra9B1OueGZfDWbwbLWA9b LTOdfPVreN4kpqU/D9WbG5zPSVPNqON6/UbW5cGdDSFcL6z3O7ndW8zk0m9cn3Fd+DnDpBPX TK99iApNtuTaL5QUtUr24yfxE7EcN+aclXcVuTXB7avpb08lluKMREMt5qLiRACqh+g4cwIA AA== |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 58 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Gilles Muller <Gilles.Muller@lip6.fr>, Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>, "moderated list:COCCINELLE/Semantic Patches (SmPL)" <cocci@systeme.lip6.fr> |
| X-Original-Date | Tue, 22 Sep 2015 15:09:41 +0200 |
| X-Original-Message-ID | <56015315.507@samsung.com> |
| X-Original-References | <1442926130-17817-1-git-send-email-a.hajda@samsung.com> <alpine.DEB.2.10.1509221453541.6225@hadrien> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1230175 |
Show key headers only | View raw
On 09/22/2015 02:58 PM, Julia Lawall wrote:
>
> On Tue, 22 Sep 2015, Andrzej Hajda wrote:
>
>> kbuild/gcc uses -include option to include files and -I to provide paths for
>> #include <> directive. The same is true for spatch.
>>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> ---
>> scripts/coccicheck | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>> index bbf901a..6d84b05 100755
>> --- a/scripts/coccicheck
>> +++ b/scripts/coccicheck
>> @@ -30,7 +30,6 @@ FLAGS="$SPFLAGS --very-quiet"
>> # spatch only allows include directories with the syntax "-I include"
>> # while gcc also allows "-Iinclude" and "-include include"
>> COCCIINCLUDE=${LINUXINCLUDE//-I/-I }
>> -COCCIINCLUDE=${COCCIINCLUDE//-include/-I}
> I'm not sure of the meaning of the above notation, nor what is the
> intention. Coccinelle does have a --include option, but it doesn't mean
> the same thing as -I. It is a way to have a file be included that is not
> included according to the normal inclusion strategy. For example, if a.h
> includes b.h which includes c.h, and if one considers that c.h is really
> important for having the right type information, but one doesn't want the
> cost of including everything via --recursive-includes, then one could put
> --include c.h.
This option has the same meaning for gcc.
But the patch is incorrect. It should be:
COCCIINCLUDE=${COCCIINCLUDE// -include/ --include}
gcc option '-include' should be converted to spatch option '--include',
ie one minus should be added.
Regards
Andrzej
>
> julia
>
>
>> if [ "$C" = "1" -o "$C" = "2" ]; then
>> ONLINE=1
>> --
>> 1.9.1
>>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Coccinelle: remove incorrect -include option transformation Andrzej Hajda <a.hajda@samsung.com> - 2015-09-22 14:50 +0200
Re: [PATCH] Coccinelle: remove incorrect -include option transformation Julia Lawall <julia.lawall@lip6.fr> - 2015-09-22 15:00 +0200
Re: [PATCH] Coccinelle: remove incorrect -include option transformation Andrzej Hajda <a.hajda@samsung.com> - 2015-09-22 15:20 +0200
Re: [PATCH] Coccinelle: remove incorrect -include option transformation Julia Lawall <julia.lawall@lip6.fr> - 2015-09-22 15:30 +0200
Re: [PATCH] Coccinelle: remove incorrect -include option transformation Julia Lawall <julia.lawall@lip6.fr> - 2015-09-22 15:10 +0200
csiph-web