Re: [PATCH] Add virt directory to the top Makefile

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Add virt directory to the top Makefile
Date	2015-09-22 12:20 +0200
Message-ID	<qbsQ2-2oh-7@gated-at.bofh.it> (permalink)
References	<qbrKi-Rt-19@gated-at.bofh.it> <qbs3G-1ei-67@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 22/09/2015 11:20, Michal Marek wrote:
> On 2015-09-22 10:47, Feng Wu wrote:
>> We need to build files in virt/lib/, which are now used by
>> KVM and VFIO, so add virt directory to the top Makefile.
>>
>> Signed-off-by: Feng Wu <feng.wu@intel.com>
>> ---
>>  Makefile              | 8 +++++---
>>  arch/x86/kvm/Makefile | 3 ---
>>  virt/Makefile         | 1 +
>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>  create mode 100644 virt/Makefile
> 
> I assume this will go through the kvm tree, is that correct?

Yes.  Feng, can you send a v2 of this patch for Michal to ack?


Paolo

> 
> 
>>  vmlinux-dirs	:= $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \
>>  		     $(core-y) $(core-m) $(drivers-y) $(drivers-m) \
>> -		     $(net-y) $(net-m) $(libs-y) $(libs-m)))
>> +		     $(net-y) $(net-m) $(libs-y) $(libs-m) $(virt-y)))
> 
> This allows to drop the explicit 'virt' entry in the KBUILD_ALLDIRS
> assignment a few lines below.
> 
> 
>> diff --git a/virt/Makefile b/virt/Makefile
>> new file mode 100644
>> index 0000000..335dc0b
>> --- /dev/null
>> +++ b/virt/Makefile
>> @@ -0,0 +1 @@
>> +obj-y	+= ./lib/
> 
> Remove the ./
> 
> Michal
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Add virt directory to the top Makefile Feng Wu <feng.wu@intel.com> - 2015-09-22 11:10 +0200
  Re: [PATCH] Add virt directory to the top Makefile Michal Marek <mmarek@suse.com> - 2015-09-22 11:30 +0200
    Re: [PATCH] Add virt directory to the top Makefile Paolo Bonzini <pbonzini@redhat.com> - 2015-09-22 12:20 +0200

csiph-web