Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1230001

Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands

Show all headers | View raw

On 21/09/15 19:40, Grant Grundler wrote:
> Jon, Ulf,
> Can we first get the current implementation upstream and _then_ add
> more patches to it?
> 
> On Mon, Sep 21, 2015 at 4:19 AM, Jon Hunter <jonathanh@nvidia.com> wrote:
> ...
>>>>> +       for (i = 0; i < num_of_cmds; i++) {
>>>>> +               err = __mmc_blk_ioctl_cmd(card, md, idata[i]);
>>>>> +               if (err) {
>>>>> +                       mmc_put_card(card);
>>>>> +                       goto cmd_done;
>>>> Instead of exiting here, you should first copy to the user the data
>>>> and response of successful commands, mark the failed command as failed
>>>> and the remaining ones as "not executed".
>>>> This way, it will be easier for the user space application to find out
>>>> where the sequence failed. This especially true if some reverts are
>>>> needed.
>>>
>>> Yes that sounds like a sensible thing to do. I will incorporate that change.
> 
> I also liked Gwendal's idea and incorporated that into our 3.18 kernel
> tree here:
>     https://chromium-review.googlesource.com/#/c/299956
> 
> (this is on top of Jon's most recently proposed patch - we'll align
> with what lands shortly)
> 
> But as I've demonstrated, this can be a separate patch.

Yes that's fine with me. I have just posted a V4 to address Ulf's last
comment.

Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3] mmc: block: Add new ioctl to send multi commands Jon Hunter <jonathanh@nvidia.com> - 2015-09-14 17:10 +0200
  Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Grant Grundler <grundler@chromium.org> - 2015-09-14 18:40 +0200
  Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Ulf Hansson <ulf.hansson@linaro.org> - 2015-09-16 13:10 +0200
    Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Jon Hunter <jonathanh@nvidia.com> - 2015-09-16 18:10 +0200
      Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Ulf Hansson <ulf.hansson@linaro.org> - 2015-09-17 09:00 +0200
        Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Jon Hunter <jonathanh@nvidia.com> - 2015-09-18 12:30 +0200
  Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Gwendal Grignou <gwendal@chromium.org> - 2015-09-16 20:00 +0200
    Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Jon Hunter <jonathanh@nvidia.com> - 2015-09-21 12:00 +0200
      Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Jon Hunter <jonathanh@nvidia.com> - 2015-09-21 13:30 +0200
        Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Grant Grundler <grundler@google.com> - 2015-09-21 20:50 +0200
          Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands Jon Hunter <jonathanh@nvidia.com> - 2015-09-22 11:30 +0200

csiph-web