Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1229989
| From | Dmitry Vyukov <dvyukov@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] lib: fix data race in rhashtable_rehash_one |
| Date | 2015-09-22 11:00 +0200 |
| Message-ID | <qbrAD-qV-23@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <qb9u3-83M-29@gated-at.bofh.it> <qbaJt-1m5-15@gated-at.bofh.it> <qbhKV-3ep-7@gated-at.bofh.it> <qbinD-4dy-5@gated-at.bofh.it> <qbr7B-8kH-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Sep 22, 2015 at 10:19 AM, Thomas Graf <tgraf@suug.ch> wrote: > On 09/21/15 at 04:03pm, Eric Dumazet wrote: >> What I said is : >> >> In @head you already have the correct nulls value, from hash table. >> >> You do not need to recompute this value, and/or test if hash table chain >> is empty. >> >> If hash bucket is empty, it contains the appropriate NULLS value. >> >> If you are paranoiac add this debugging check : >> >> if (rht_is_a_nulls(head)) >> BUG_ON(head != (struct rhash_head *)rht_marker(ht, new_hash)); >> >> >> Therefore, simply fix the bug and unnecessary code with : > > You are absolutely right Eric. Do you want to revise your patch Dmitry? > Eric's proposed fix absolutely the best way to fix this. Mailed v2 of the patch. -- Dmitry Vyukov, Software Engineer, dvyukov@google.com Google Germany GmbH, Dienerstraße 12, 80331, München Geschäftsführer: Graham Law, Christine Elizabeth Flores Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] lib: fix data race in rhashtable_rehash_one Dmitry Vyukov <dvyukov@google.com> - 2015-09-21 10:10 +0200
Re: [PATCH] lib: fix data race in rhashtable_rehash_one Eric Dumazet <eric.dumazet@gmail.com> - 2015-09-21 15:40 +0200
Re: [PATCH] lib: fix data race in rhashtable_rehash_one Eric Dumazet <eric.dumazet@gmail.com> - 2015-09-21 17:00 +0200
Re: [PATCH] lib: fix data race in rhashtable_rehash_one Eric Dumazet <eric.dumazet@gmail.com> - 2015-09-21 17:20 +0200
Re: [PATCH] lib: fix data race in rhashtable_rehash_one Dmitry Vyukov <dvyukov@google.com> - 2015-09-21 17:20 +0200
Re: [PATCH] lib: fix data race in rhashtable_rehash_one Thomas Graf <tgraf@suug.ch> - 2015-09-22 00:30 +0200
Re: [PATCH] lib: fix data race in rhashtable_rehash_one Eric Dumazet <eric.dumazet@gmail.com> - 2015-09-22 01:10 +0200
Re: [PATCH] lib: fix data race in rhashtable_rehash_one Thomas Graf <tgraf@suug.ch> - 2015-09-22 10:30 +0200
Re: [PATCH] lib: fix data race in rhashtable_rehash_one Dmitry Vyukov <dvyukov@google.com> - 2015-09-22 11:00 +0200
Re: [PATCH] lib: fix data race in rhashtable_rehash_one Herbert Xu <herbert@gondor.apana.org.au> - 2015-09-22 17:20 +0200
csiph-web