Re: [PATCH 30/38] leds: flash: remove invalid check

From	Jacek Anaszewski <j.anaszewski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 30/38] leds: flash: remove invalid check
Date	2015-09-22 09:40 +0200
Message-ID	<qbqlc-7b4-7@gated-at.bofh.it> (permalink)
References	<qb9u2-83M-3@gated-at.bofh.it> <qb9DJ-8gq-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrzej,

On 09/21/2015 03:34 PM, Andrzej Hajda wrote:
> Unsigned cannot be lesser than zero.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>   drivers/leds/led-class-flash.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
> index 3b25734..c209077 100644
> --- a/drivers/leds/led-class-flash.c
> +++ b/drivers/leds/led-class-flash.c
> @@ -108,7 +108,7 @@ static ssize_t flash_strobe_store(struct device *dev,
>   	if (ret)
>   		goto unlock;
>
> -	if (state < 0 || state > 1) {
> +	if (state > 1) {
>   		ret = -EINVAL;
>   		goto unlock;
>   	}
>

Merged, thanks.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 30/38] leds: flash: remove invalid check Andrzej Hajda <a.hajda@samsung.com> - 2015-09-21 15:50 +0200
  Re: [PATCH 30/38] leds: flash: remove invalid check Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-09-22 09:40 +0200

csiph-web