Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1229905

Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 9/21/15 9:14 PM, Jarod Wilson wrote:
> Just switching to adapter->io_addr everywhere seems to not work as 
> noted above. :\ Note that I'm also chasing this from the other end 
> with the author of the pci patches that seem to have triggered this, 
> so the real bug might be over in pci-land, but hardening against 
> explosions in igb still seems like a worthwhile effort here.

My understanding is that there can be problems if too many writes to a
removed device happen. That is why ixgbe avoids doing that by testing
for removal in some places. The io_addr does get used in the transmit
path simply to avoid adding a test to that hot path. That approach
seems to be working well for ixgbe.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] igb: add more checks for disconnected adapter Jarod Wilson <jarod@redhat.com> - 2015-09-21 19:20 +0200
  Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected  adapter Alexander Duyck <alexander.duyck@gmail.com> - 2015-09-22 00:00 +0200
    Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected  adapter Jarod Wilson <jarod@redhat.com> - 2015-09-22 06:20 +0200
      Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected  adapter Mark Rustad <mrustad@gmail.com> - 2015-09-22 07:10 +0200
      Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected  adapter Alexander Duyck <alexander.duyck@gmail.com> - 2015-09-22 07:30 +0200

csiph-web