Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1229672

Re: [PATCH] ata:Fix error handling in the function ahci_pci_reset_controller

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ata:Fix error handling in the function ahci_pci_reset_controller
Date 2015-09-21 21:10 +0200
Message-ID <qbeDo-7aE-25@gated-at.bofh.it> (permalink)
References <qbeDo-7aE-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Sep 18, 2015 at 11:27:47PM -0400, Nicholas Krause wrote:
> This fixes error handling in the function ahci_pci_reset_controller
> to properly check if the call to ahci_reset_controller fails and
> if return -EIO to this function's caller rather then continuing
> with this function's intended work if the controller cannot be
> reset properly for this ahci pci based device.

Maybe... I don't know.  What do we gain by failing resume?  Reporting
is fine but what'd be the recovery action?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] ata:Fix error handling in the function  ahci_pci_reset_controller Tejun Heo <tj@kernel.org> - 2015-09-21 21:10 +0200

csiph-web