Re: [RFC PATCH 0/3] fix *pbl format support

From	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 0/3] fix *pbl format support
Date	2015-09-21 18:30 +0200
Message-ID	<qbc8y-3vr-23@gated-at.bofh.it> (permalink)
References	<q9gSZ-8o1-13@gated-at.bofh.it> <q9k0y-4mj-7@gated-at.bofh.it> <q9p0e-309-25@gated-at.bofh.it> <q9rEK-6RI-19@gated-at.bofh.it> <qbaJs-1m5-1@gated-at.bofh.it>
Organization	D03

Show all headers | View raw

On Mon, Sep 21 2015, Maurizio Lombardi <mlombard@redhat.com> wrote:

> Hi Rasmus,
>
> On 09/16/2015 10:35 PM, Rasmus Villemoes wrote:
>> 
>> I just remembered: I noticed a while ago that the qualifier member is
>> only used inside format_decode (in the end, the information is folded
>> into the type member), so one might as well use a local variable for
>> that. This gives option (3): Make field_width a 24 bit bitfield. I think
>> that should be sufficient for any realistic bitmap that one would
>> print. The patch is also rather small. Surprisingly, bloat-o-meter even
>> says that it's also a net win in code size:
>
> I tested your patch with scsi-debug and it works for me:

Thanks for testing it! What do people think of this option?

Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/3] fix *pbl format support Maurizio Lombardi <mlombard@redhat.com> - 2015-09-16 11:10 +0200
  [RFC PATCH 2/3] lib/vsprintf.c: append "..." if the *pb[l] output has been truncated. Maurizio Lombardi <mlombard@redhat.com> - 2015-09-16 11:10 +0200
  [RFC PATCH 1/3] lib/vsprintf.c: Do not pass printf_spec by value on stack. Maurizio Lombardi <mlombard@redhat.com> - 2015-09-16 11:10 +0200
  [RFC PATCH 3/3] lib/vsprintf.c: increase the size of the field_width variable Maurizio Lombardi <mlombard@redhat.com> - 2015-09-16 11:10 +0200
  Re: [RFC PATCH 0/3] fix *pbl format support Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-16 14:30 +0200
    Re: [RFC PATCH 0/3] fix *pbl format support Maurizio Lombardi <mlombard@redhat.com> - 2015-09-16 15:00 +0200
    Re: [RFC PATCH 0/3] fix *pbl format support Tejun Heo <tj@kernel.org> - 2015-09-16 19:50 +0200
      Re: [RFC PATCH 0/3] fix *pbl format support Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-16 22:40 +0200
        Re: [RFC PATCH 0/3] fix *pbl format support Maurizio Lombardi <mlombard@redhat.com> - 2015-09-21 17:00 +0200
          Re: [RFC PATCH 0/3] fix *pbl format support Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-21 18:30 +0200

csiph-web