[patch] devres: fix a for loop bounds check

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] devres: fix a for loop bounds check
Date	2015-09-21 18:30 +0200
Message-ID	<qbc8y-3vr-13@gated-at.bofh.it> (permalink)
References	<qbc8y-3vr-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The iomap[] array has PCIM_IOMAP_MAX (6) elements and not
DEVICE_COUNT_RESOURCE (16).  This bug was found using a static checker.
It may be that the "if (!(mask & (1 << i)))" check means we never
actually go past the end of the array in real life.

Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/lib/devres.c b/lib/devres.c
index f13a246..8c85672 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -418,7 +418,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
 	if (!iomap)
 		return;
 
-	for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
+	for (i = 0; i < PCIM_IOMAP_MAX; i++) {
 		if (!(mask & (1 << i)))
 			continue;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] devres: fix a for loop bounds check Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-21 18:30 +0200
  Re: [patch] devres: fix a for loop bounds check Tejun Heo <htejun@gmail.com> - 2015-09-21 19:50 +0200

csiph-web