Re: [PATCH] fs/super.c: use && instead of & for warn_on condition

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fs/super.c: use && instead of & for warn_on condition
Date	2015-09-21 17:50 +0200
Message-ID	<qbbvR-2wt-37@gated-at.bofh.it> (permalink)
References	<qbbvR-2wt-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/21, Vincent Stehlé wrote:
>
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait)
>  	else
>  		ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1);
>
> -	WARN_ON(force_trylock & !ret);
> +	WARN_ON(force_trylock && !ret);

OOPS! yes, this is a typo, thanks! Harmless in this particular case,
but still.

Acked-by: Oleg Nesterov <oleg@redhat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] fs/super.c: use && instead of & for warn_on condition Oleg Nesterov <oleg@redhat.com> - 2015-09-21 17:50 +0200

csiph-web