Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231677

Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges.

Show all headers | View raw

On Wednesday 23 September 2015 09:00:36 David Daney wrote:
> On 09/23/2015 12:51 AM, Arnd Bergmann wrote:
> > On Tuesday 22 September 2015 17:09:56 David Daney wrote:
> >> From: David Daney <david.daney@cavium.com>
> >>
> >> The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges.
> >> Since it is arm64, create a new quirks.c file there to contain arm64
> >> related quirks.  Add the ThunderX bridge quirk, gated by a new config
> >> variable, so that it can be disabled for kernels that aren't expected
> >> to be used on ThunderX.
> >>
> >> Signed-off-by: David Daney <david.daney@cavium.com>
> >> ---
> >>   arch/arm64/Kconfig         | 11 +++++++++++
> >>   arch/arm64/kernel/Makefile |  2 +-
> >>   arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++
> >>   3 files changed, 48 insertions(+), 1 deletion(-)
> >>   create mode 100644 arch/arm64/kernel/quirks.c
> >>
> >
> > Looks reasonable to me. Just one question: Is the same bridge used
> > on MIPS machines?
> 
> No.  The MIPS64 based OCTEON family of SoCs does not contain 
> PCI-buses/config-space/bridges for on-chip hardware blocks.  The on-chip 
> blocks in OCTEON are all platform devices.  So, ...
> 
> > If so, maybe it should be moved to drivers/pci/quirks.c
> > instead for better reuse.
> 
> The quirk is specific to some arm64 based SoCs, thus my idea to have 
> arch specific quirks.

Ok.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges. David Daney <ddaney.cavm@gmail.com> - 2015-09-23 02:20 +0200
  Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges. Arnd Bergmann <arnd@arndb.de> - 2015-09-23 10:00 +0200
    Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges. David Daney <ddaney@caviumnetworks.com> - 2015-09-23 18:10 +0200
      Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges. Arnd Bergmann <arnd@arndb.de> - 2015-09-23 21:40 +0200
  Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges. Will Deacon <will.deacon@arm.com> - 2015-09-23 20:50 +0200

csiph-web