Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231667

Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags

Show all headers | View raw

On 09/23/2015 01:05 PM, Murali Karicheri wrote:
> On 09/22/2015 12:08 PM, Nishanth Menon wrote:
[...]

>> diff --git
>> a/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> index 59d7a46f85eb..800d2d02e27b 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> @@ -9,12 +9,26 @@ Required properties:
>>      the form "ti,keystone-*". Generic devices like gic, arch_timers,
>> ns16550
>>      type UART should use the specified compatible for those devices.
>>
>> +SoC families:
>> +
>> +- Keystone 2 generic SoC:
>> +   compatible = "ti,keystone"
>> +
>> +SoCs:
>> +
>> +- Keystone 2 Hawking/Kepler
>> +   compatible = ti,k2hk", "ti,keystone"
>> +- Keystone 2 Lamarr
>> +   compatible = ti,k2l", "ti,keystone"
>> +- Keystone 2 Edison
>> +   compatible = ti,k2e", "ti,keystone"
>> +
>>   Boards:
>>   -  Keystone 2 Hawking/Kepler EVM
>> -   compatible = "ti,k2hk-evm","ti,keystone"
>> +   compatible = "ti,k2hk-evm", "ti,k2hk", "ti,keystone"
>>
>>   -  Keystone 2 Lamarr EVM
>> -   compatible = "ti,k2l-evm","ti,keystone"
>> +   compatible = "ti,k2l-evm", "ti, k2l", "ti,keystone"
>>
>>   -  Keystone 2 Edison EVM
>> -   compatible = "ti,k2e-evm","ti,keystone"
>> +   compatible = "ti,k2e-evm", "ti,k2e", "ti,keystone"
>>
> DTS takes care of the difference in the hardware and If there SoC
> specific customization required outside this, then it is best to include
> this as part of that change. In the past, I believe we didn't do it due
> to the same reason as above.

Right now, they all claim to be the same keystone SoC -> which is
inaccurate at the very least, and downright wrong IMHO since k2e/hk and
l are different SoCs - even though they belong to keystone family, they
are as similar as OMAP4 is to OMAP5 is to DRA7. This is similar to how
various other SoCs distinguish between SoCs as well.

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags Nishanth Menon <nm@ti.com> - 2015-09-22 18:10 +0200
  Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Murali Karicheri <m-karicheri2@ti.com> - 2015-09-23 20:10 +0200
    Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Nishanth Menon <nm@ti.com> - 2015-09-23 21:20 +0200
  Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-09-23 20:30 +0200
    Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Murali Karicheri <m-karicheri2@ti.com> - 2015-09-24 16:10 +0200
      Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Nishanth Menon <nm@ti.com> - 2015-09-24 16:30 +0200
        Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Murali Karicheri <m-karicheri2@ti.com> - 2015-09-24 18:00 +0200
          Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Nishanth Menon <nm@ti.com> - 2015-09-25 17:00 +0200
            Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-09-25 17:20 +0200
              Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Nishanth Menon <nm@ti.com> - 2015-09-25 18:10 +0200
                Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-09-25 18:20 +0200
                Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Nishanth Menon <menon.nishanth@gmail.com> - 2015-09-25 19:40 +0200
                Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-10-02 18:20 +0200
                Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Nishanth Menon <nm@ti.com> - 2015-10-04 01:50 +0200
                Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2015-10-04 02:20 +0200
                Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific  compatible flags Murali Karicheri <m-karicheri2@ti.com> - 2015-09-30 16:40 +0200

csiph-web