Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1231614
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Patrick Marlier <patrick.marlier@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage |
| Date | Wed, 23 Sep 2015 20:00:03 +0200 |
| Message-ID | <qbWuL-2YN-45@gated-at.bofh.it> (permalink) |
| References | <ppr9U-5Rn-7@gated-at.bofh.it> <ppuKt-2Tu-7@gated-at.bofh.it> <ppv3P-3oB-7@gated-at.bofh.it> <pqOnM-6aw-5@gated-at.bofh.it> <priFb-zN-3@gated-at.bofh.it> <prtAC-8g0-19@gated-at.bofh.it> <prXS2-31g-7@gated-at.bofh.it> <q7FCa-7II-17@gated-at.bofh.it> <q8coq-4vu-19@gated-at.bofh.it> <q8iau-4i8-9@gated-at.bofh.it> <qbCPo-8bs-9@gated-at.bofh.it> |
| X-Original-To | paulmck@linux.vnet.ibm.com |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=8FRxw5tJcRhkqm0BXIx8uPsNoG96dfGpeG4XsKGmo/s=; b=oFtapxdxTnN15QJljhJOnViPb+M9ieuKl7Dz5rBpQad8EBoDuJZQIiDJFVfLhb91Do y9K3gIkvtrY6Vm4BuseqoxrBMm5F52vP3aYnwxlXRlVSiX1uf/xACMdZb0Xh9c4BxemW jeo8jTSlipFH/SsSzM5MD+gt6EixMFIW4An+7JMMaRo28yn/PHsQS+3Z+PqeTvyA6fyE rdIvSibhUPtUPd7Qjtn4QUqHu7/4ELtauHpYBtHw7u3HxESRkBbDjarigluM9oO1CBhM SYk6JFftWEWY7+F2BXjlExGIZ+jWVjaKbqr2hO44uErghT6/viMr4FqPA57r031NBabb n0dQ== |
| X-Received | by 10.180.8.232 with SMTP id u8mr2198237wia.26.1443031078728; Wed, 23 Sep 2015 10:57:58 -0700 (PDT) |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=windows-1252; format=flowed |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 46 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Steven Rostedt <rostedt@goodmis.org>, NeilBrown <neilb@suse.de>, linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, wangyun@linux.vnet.ibm.com |
| X-Original-Date | Wed, 23 Sep 2015 19:57:53 +0200 |
| X-Original-Message-ID | <5602E821.800@gmail.com> |
| X-Original-References | <1431470787-4702-3-git-send-email-paulmck@linux.vnet.ibm.com> <20150512223853.55e0ed90@grimm.local.home> <20150513125839.371ef677@notabene.brown> <5557819E.1060001@gmail.com> <20150518120647.0c3cecd8@notabene.brown> <20150518094321.2012a66a@gandalf.local.home> <20150519220725.GA6776@linux.vnet.ibm.com> <20150911230554.GA26655@linux.vnet.ibm.com> <55F54AA9.3020102@gmail.com> <20150913161023.GM4029@linux.vnet.ibm.com> <20150922205000.GA29408@linux.vnet.ibm.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1231614 |
Show key headers only | View raw
On 09/22/2015 10:50 PM, Paul E. McKenney wrote: > On Sun, Sep 13, 2015 at 09:10:24AM -0700, Paul E. McKenney wrote: >> On Sun, Sep 13, 2015 at 12:06:33PM +0200, Patrick Marlier wrote: > > [ . . . ] > >>> Paul, >>> >>> This sounds good to me. It should fix the performance issue (will >>> check with my benchmark). >> >> Thank you, looking forward to seeing the results! > > Just following up -- how is the benchmarking going? Note that in my module I am using the kernel version 3.16.0-31 (I ported your change). Here the results of my benchmark that tests rculist in the case of read only. # 1st column : The number of threads # 2nd : ops/s the original version # 3rd : ops/s your version with lockless_dereference 1 883923 1747554 2 1741441 3543062 3 2462360 5103647 4 3437273 7176608 6 5155803 9812348 8 6718111 13330050 10 8519227 17458294 12 9773632 20298897 14 11555198 23191424 16 11643264 25125712 I get same performance with my patch. So indeed it fixes the performance problem I was seeing. Thanks a lot! -- Pat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-09-22 23:00 +0200
Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage Patrick Marlier <patrick.marlier@gmail.com> - 2015-09-23 20:00 +0200
Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-09-24 06:50 +0200
csiph-web