Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231603

Re: [PATCH v4 2/5] soc: sunxi: Add driver for Allwinner Reduced Serial Bus

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Sep 24, 2015 at 12:05:18AM +0800, Chen-Yu Tsai wrote:

> +static int sunxi_rsb_device_probe(struct device *dev)
> +{
> +	const struct sunxi_rsb_driver *drv = to_sunxi_rsb_driver(dev->driver);
> +	struct sunxi_rsb_device *rdev = to_sunxi_rsb_device(dev);
> +	int ret;
> +
> +	if (dev->bus != &sunxi_rsb_bus)
> +		return 0;

That's a bit worrying...  why might this get called for something other
than a rsb device?

> +struct regmap *devm_regmap_init_sunxi_rsb(struct sunxi_rsb_device *rdev,
> +					  const struct regmap_config *config);

This should work most of the time but you might want to take a look at
the changes introduced in 3cfe7a74d42b (regmap: Use different lockdep
class for each regmap init call) and follow a similar pattern for RSB to
avoid spurious lockdep warnings in some configurations - see the commit
log for that change for a full explanation.

Otherwise the regmap bit of this looks good, I'll try to have another
look through at the rest of the code later.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] ARM: sunxi: Add Reduced Serial Bus support Chen-Yu Tsai <wens@csie.org> - 2015-09-23 18:10 +0200
  [PATCH v4 5/5] ARM: dts: sun8i: sinlinx-sina33: Enable Reduced Serial Bus controller Chen-Yu Tsai <wens@csie.org> - 2015-09-23 18:10 +0200
  [PATCH v4 3/5] ARM: dts: sun8i: Add Reduced Serial Bus controller device node to A23/A33 dtsi Chen-Yu Tsai <wens@csie.org> - 2015-09-23 18:10 +0200
  [PATCH v4 1/5] soc: sunxi: Add Allwinner Reduced Serial Bus (RSB) controller bindings Chen-Yu Tsai <wens@csie.org> - 2015-09-23 18:10 +0200
    Re: [PATCH v4 1/5] soc: sunxi: Add Allwinner Reduced Serial Bus  (RSB) controller bindings Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-24 09:00 +0200
  [PATCH v4 2/5] soc: sunxi: Add driver for Allwinner Reduced Serial Bus Chen-Yu Tsai <wens@csie.org> - 2015-09-23 18:10 +0200
    Re: [PATCH v4 2/5] soc: sunxi: Add driver for Allwinner Reduced  Serial Bus Mark Brown <broonie@kernel.org> - 2015-09-23 20:00 +0200
      Re: [linux-sunxi] Re: [PATCH v4 2/5] soc: sunxi: Add driver for  Allwinner Reduced Serial Bus Chen-Yu Tsai <wens@csie.org> - 2015-09-24 10:30 +0200
  [PATCH v4 4/5] ARM: dts: sun8i: ippo-q8h-v5: Enable Reduced Serial Bus controller Chen-Yu Tsai <wens@csie.org> - 2015-09-23 18:10 +0200

csiph-web