[PATCH 5/7] net: netcp: check for interface handle in netcp_module_probe()

From	Murali Karicheri <m-karicheri2@ti.com>
Newsgroups	linux.kernel
Subject	[PATCH 5/7] net: netcp: check for interface handle in netcp_module_probe()
Date	2015-09-23 19:40 +0200
Message-ID	<qbWbo-2Bf-19@gated-at.bofh.it> (permalink)
References	<qbWbn-2Bf-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Currently netcp_module_probe() doesn't check the return value of
of_parse_phandle() that points to the interface data for the
module and then pass the node ptr to the module which is incorrect.
Check for return value and free the intf_modpriv if there is error.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 drivers/net/ethernet/ti/netcp_core.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index 97e2629..d39dce3 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -299,6 +299,11 @@ static int netcp_module_probe(struct netcp_device *netcp_device,
 		interface = of_parse_phandle(netcp_intf->node_interface,
 					     module->name, 0);
 
+		if (!interface) {
+			devm_kfree(dev, intf_modpriv);
+			continue;
+		}
+
 		intf_modpriv->netcp_priv = netcp_intf;
 		intf_modpriv->netcp_module = module;
 		list_add_tail(&intf_modpriv->intf_list,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 5/7] net: netcp: check for interface handle in netcp_module_probe() Murali Karicheri <m-karicheri2@ti.com> - 2015-09-23 19:40 +0200

csiph-web