Re: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo Gen2

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo Gen2
Date	2015-09-23 15:00 +0200
Message-ID	<qbROr-4Bm-31@gated-at.bofh.it> (permalink)
References	<qbsQ1-2oh-3@gated-at.bofh.it> <qbsQ2-2oh-15@gated-at.bofh.it> <qbwTE-86z-21@gated-at.bofh.it> <qbNUv-7t6-29@gated-at.bofh.it> <qbREL-4pV-39@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Wed, 2015-09-23 at 14:48 +0200, Thierry Reding wrote:
> > > > 

> On Wed, Sep 23, 2015 at 11:41:26AM +0300, Andy Shevchenko wrote:
> > On Tue, 2015-09-22 at 16:37 +0200, Thierry Reding wrote:
> > > On Tue, Sep 22, 2015 at 01:10:19PM +0300, Andy Shevchenko wrote:
> > 

> > > 
> > > >  		.of_match_table = pca9685_dt_ids,
> > > 
> > > Similarly to the above, this should use of_match_ptr(), which in 
> > > turn
> > > will require #ifdef protection for the table to avoid warnings.
> > 
> > Hmm... my patch do not touches that part. Perhaps another patch for
> > this?
> 
> Your patch does touch that part by removing the dependency on OF. 
> That
> makes it possible to build this code with !OF, which in turn would 
> make
> the OF match table unused.

Ah, you're right. Will amend this part as well.
Thanks!

> 
> Thierry

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo Gen2 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-22 12:20 +0200
  Re: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo  Gen2 Thierry Reding <thierry.reding@gmail.com> - 2015-09-22 16:40 +0200
    Re: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo  Gen2 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-23 10:50 +0200
      Re: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo  Gen2 Thierry Reding <thierry.reding@gmail.com> - 2015-09-23 14:50 +0200
        Re: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo  Gen2 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-23 15:00 +0200

csiph-web