Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231308

RE: [PATCH] f2fs: fix to correct freed section number during gc

Show all headers | View raw

Hi Jaegeuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Wednesday, September 23, 2015 6:54 AM
> To: Chao Yu
> Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] f2fs: fix to correct freed section number during gc
> 
> Hi Chao,
> 
> On Tue, Sep 22, 2015 at 09:18:18PM +0800, Chao Yu wrote:
> > We pass 'nfree' to has_not_enough_free_secs to check whether there is
> > enough free section, but 'nfree' indicates the number of segment gced,
> > should alter the value to section number.
> 
> Yeah, but I think we need to increase nfree only when an entire section is gced
> completely, since sometimes nfree can be increased across sections.

Agree, I will fix that.

Still have one question, for foreground gc, why would we give up retry writing
out pages of last victim, but trying to select another victim for cleanup?
Will new introduced method cause long latency for caller than before?

Thanks,


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] f2fs: fix to correct freed section number during gc Chao Yu <chao2.yu@samsung.com> - 2015-09-22 15:20 +0200
  Re: [PATCH] f2fs: fix to correct freed section number during gc Jaegeuk Kim <jaegeuk@kernel.org> - 2015-09-23 01:00 +0200
    RE: [PATCH] f2fs: fix to correct freed section number during gc Chao Yu <chao2.yu@samsung.com> - 2015-09-23 12:20 +0200
      Re: [PATCH] f2fs: fix to correct freed section number during gc Jaegeuk Kim <jaegeuk@kernel.org> - 2015-09-23 23:10 +0200
        Re: [f2fs-dev] [PATCH] f2fs: fix to correct freed section number during gc Chao Yu <yuchaochina@hotmail.com> - 2015-09-25 14:50 +0200

csiph-web