Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231337

Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock()

Show all headers | View raw

On Wed, Sep 23, 2015 at 08:06:16AM +0200, Sedat Dilek wrote:
> Without reverting the below culprit ppp patch...
> 
> commit/?id=8cb775bc0a34dc596837e7da03fd22c747be618b
> ("ppp: fix device unregistration upon netns deletion")
> 
> ...I have an unstable Internet connection via Network-Manager/ModemManager.
> 
> First I saw this with Linux v4.2.
> 

Thanks for reporting the issue. Can you test this patch ?

---
diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index 0481daf..ed00446 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -2755,6 +2755,7 @@ static struct ppp *ppp_create_interface(struct net *net, int unit,
 	 */
 	dev_net_set(dev, net);
 
+	rtnl_lock();
 	mutex_lock(&pn->all_ppp_mutex);
 
 	if (unit < 0) {
@@ -2785,7 +2786,7 @@ static struct ppp *ppp_create_interface(struct net *net, int unit,
 	ppp->file.index = unit;
 	sprintf(dev->name, "ppp%d", unit);
 
-	ret = register_netdev(dev);
+	ret = register_netdevice(dev);
 	if (ret != 0) {
 		unit_put(&pn->units_idr, unit);
 		netdev_err(ppp->dev, "PPP: couldn't register device %s (%d)\n",
@@ -2797,6 +2798,7 @@ static struct ppp *ppp_create_interface(struct net *net, int unit,
 
 	atomic_inc(&ppp_unit_count);
 	mutex_unlock(&pn->all_ppp_mutex);
+	rtnl_unlock();
 
 	*retp = 0;
 	return ppp;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking  dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock() Guillaume Nault <g.nault@alphalink.fr> - 2015-09-23 12:50 +0200
  Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking  dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock() Sedat Dilek <sedat.dilek@gmail.com> - 2015-09-23 22:50 +0200
    Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking  dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock() Sedat Dilek <sedat.dilek@gmail.com> - 2015-09-23 23:30 +0200
      Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking  dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock() Guillaume Nault <g.nault@alphalink.fr> - 2015-09-24 13:10 +0200
        Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking  dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock() Sedat Dilek <sedat.dilek@gmail.com> - 2015-09-24 18:20 +0200
          Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking  dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock() David Miller <davem@davemloft.net> - 2015-09-24 20:10 +0200
            Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking  dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock() Sedat Dilek <sedat.dilek@gmail.com> - 2015-09-25 08:00 +0200
              Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking  dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock() Sedat Dilek <sedat.dilek@gmail.com> - 2015-09-25 10:50 +0200

csiph-web