Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231297

Re: [PATCH 2/2] selftests/userfaultfd: improve syscall number definition

Show all headers | View raw

On Tue, 2015-09-22 at 18:15 +0100, Andre Przywara wrote:
> On 22/09/15 15:06, Andrea Arcangeli wrote:
> > Andre, could you see if linux-next (which includes -mm) works for you
> > by just running "cd tools/testing/selftests/vm/ && make"? If there's
> > any further change required could you diff it against linux-next?
> 
> This doesn't compile now for me, because it looks into
> /usr/include/asm/unistd.h, which I keep to the distribution copy of it.
> Also linux/userfaultfd.h is missing, because it's brand new.
...
> I guess the right solution would be to hack the Makefile to set the
> include path to the kernel's copy of include/uapi, though I am not sure
> this works cleanly for different architectures and separate build
> directories. I will give this a try ...

Not that's not the right solution.

The right solution is to export the kernel headers, the Makefile will pick them
up (at least in linux-next):

  $ cd linux
  $ make headers_install
  $ ls usr/include/
  asm/  asm-generic/  drm/  linux/  misc/  mtd/  rdma/  scsi/  sound/  uapi/  video/  xen/
  $ make -C tools/testing/selftests TARGETS=vm
  ...
  $ ls tools/testing/selftests/vm/userfaultfd
  tools/testing/selftests/vm/userfaultfd*

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] selftests/userfaultfd: fix build Andre Przywara <andre.przywara@arm.com> - 2015-09-22 12:50 +0200
  [PATCH 1/2] userfaultfd: remove kernel header include from uapi header Andre Przywara <andre.przywara@arm.com> - 2015-09-22 12:50 +0200
  [PATCH 2/2] selftests/userfaultfd: improve syscall number definition Andre Przywara <andre.przywara@arm.com> - 2015-09-22 12:50 +0200
    Re: [PATCH 2/2] selftests/userfaultfd: improve syscall number  definition Shuah Khan <shuahkh@osg.samsung.com> - 2015-09-22 15:50 +0200
      Re: [PATCH 2/2] selftests/userfaultfd: improve syscall number  definition Andrea Arcangeli <aarcange@redhat.com> - 2015-09-22 16:10 +0200
        Re: [PATCH 2/2] selftests/userfaultfd: improve syscall number  definition Andre Przywara <andre.przywara@arm.com> - 2015-09-22 19:20 +0200
          Re: [PATCH 2/2] selftests/userfaultfd: improve syscall number  definition Michael Ellerman <mpe@ellerman.id.au> - 2015-09-23 12:00 +0200
            Re: [PATCH 2/2] selftests/userfaultfd: improve syscall number  definition Andre Przywara <andre.przywara@arm.com> - 2015-09-23 15:20 +0200
              Re: [PATCH 2/2] selftests/userfaultfd: improve syscall number  definition Michael Ellerman <mpe@ellerman.id.au> - 2015-09-24 04:10 +0200

csiph-web