Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0
Date	2015-09-23 11:30 +0200
Message-ID	<qbOxc-8rA-1@gated-at.bofh.it> (permalink)
References	<qbIBs-8lQ-11@gated-at.bofh.it> <qbOxc-8rA-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 22, 2015 at 06:08:59PM -0500, J. German Rivera wrote:
>  /**
> + * dprc_set_obj_label() - Set object label.
> + * @mc_io:	Pointer to MC portal's I/O object
> + * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
> + * @token:	Token of DPRC object
> + * @obj_type:	Object's type
> + * @obj_id:	Object's ID
> + * @label:	The required label. The maximum length is 16 chars.
> + *
> + * Return:	'0' on Success; Error code otherwise.
> + */
> +int dprc_set_obj_label(struct fsl_mc_io	*mc_io,
> +		       uint32_t		cmd_flags,
> +		       uint16_t		token,
> +		       char		*obj_type,
> +		       int		obj_id,
> +		       char		*label);

You can fix it in a later patch, but this documentation belongs in the
.c file instead of the .h file.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to  v4.0 Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-23 11:30 +0200
  RE: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to  v4.0 Jose Rivera <German.Rivera@freescale.com> - 2015-09-24 20:40 +0200

csiph-web