Re: [PATCH] kexec: Add prefix "kexec" to output message

From	Baoquan He <bhe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kexec: Add prefix "kexec" to output message
Date	2015-09-23 07:30 +0200
Message-ID	<qbKMW-2YL-11@gated-at.bofh.it> (permalink)
References	(4 earlier) <q8ON4-GN-3@gated-at.bofh.it> <qbyiK-1PH-35@gated-at.bofh.it> <qbHcl-67q-1@gated-at.bofh.it> <qbIi6-7Kb-3@gated-at.bofh.it> <qbKDf-2Nw-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/23/15 at 01:14pm, Minfei Huang wrote:
> On 09/23/15 at 10:49am, Baoquan He wrote:
> > This is weird, user really don't need to know each file. I saw you added
> > a new file kexec_internal.h and all three files includes it. Why not doing
> > it there to make it the same as before?
> 
> The output message format is incorrect, if other *.c (except for kexec*)
> include the kexec_internal.h.

No, I assume Dave added kexec_internal.h not to be used by other *.c.
It should be only used by kexec*.c

> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> How about defining the format like above in each *.c?
> 
> Thanks
> Minfei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] kexec: Add prefix "kexec" to output message Minfei Huang <mhuang@redhat.com> - 2015-09-22 18:10 +0200
  Re: [PATCH] kexec: Add prefix "kexec" to output message Dave Young <dyoung@redhat.com> - 2015-09-23 03:40 +0200
    Re: [PATCH] kexec: Add prefix "kexec" to output message Baoquan He <bhe@redhat.com> - 2015-09-23 04:50 +0200
      Re: [PATCH] kexec: Add prefix "kexec" to output message Minfei Huang <mhuang@redhat.com> - 2015-09-23 07:20 +0200
        Re: [PATCH] kexec: Add prefix "kexec" to output message Baoquan He <bhe@redhat.com> - 2015-09-23 07:30 +0200
          Re: [PATCH] kexec: Add prefix "kexec" to output message Minfei Huang <mhuang@redhat.com> - 2015-09-23 07:50 +0200
      Re: [PATCH] kexec: Add prefix "kexec" to output message Dave Young <dyoung@redhat.com> - 2015-09-23 09:10 +0200

csiph-web