Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1231082

Re: [PATCH] net: davinci_emac: Add support for fixed-link PHY

From Tony Lindgren <tony@atomide.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: davinci_emac: Add support for fixed-link PHY
Date 2015-09-23 03:20 +0200
Message-ID <qbGSZ-5LA-1@gated-at.bofh.it> (permalink)
References <qbrAC-qV-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


* Neil Armstrong <narmstrong@baylibre.com> [150922 02:01]:
> In case the DaVinci Emac is directly connected to a
> non-mdio PHY/device, it should be possible to provide
> a fixed link configuration in the DT.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Ethernet works for me with this patch:

Tested-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/net/ethernet/ti/davinci_emac.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
> index aeebc0a..6521dfb 100644
> --- a/drivers/net/ethernet/ti/davinci_emac.c
> +++ b/drivers/net/ethernet/ti/davinci_emac.c
> @@ -1861,8 +1861,12 @@ davinci_emac_of_get_pdata(struct platform_device *pdev, struct emac_priv *priv)
>  	pdata->no_bd_ram = of_property_read_bool(np, "ti,davinci-no-bd-ram");
> 
>  	priv->phy_node = of_parse_phandle(np, "phy-handle", 0);
> -	if (!priv->phy_node)
> -		pdata->phy_id = NULL;
> +	if (!priv->phy_node) {
> +		if (!of_phy_is_fixed_link(np))
> +			pdata->phy_id = NULL;
> +		else if (of_phy_register_fixed_link(np) >= 0)
> +			priv->phy_node = of_node_get(np);
> +	}
> 
>  	auxdata = pdev->dev.platform_data;
>  	if (auxdata) {
> -- 
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] net: davinci_emac: Add support for fixed-link PHY Tony Lindgren <tony@atomide.com> - 2015-09-23 03:20 +0200

csiph-web