Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1231058
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Andrew Morton <akpm@linux-foundation.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed |
| Date | Wed, 23 Sep 2015 02:10:01 +0200 |
| Message-ID | <qbFNf-4eK-15@gated-at.bofh.it> (permalink) |
| References | <qbuf8-4hk-15@gated-at.bofh.it> <qbBTk-6Qf-23@gated-at.bofh.it> <qbFNf-4eK-11@gated-at.bofh.it> |
| X-Original-To | Baoquan He <bhe@redhat.com> |
| X-Mailer | Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=US-ASCII |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 30 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | yinghai@kernel.org, dyoung@redhat.com, jroedel@suse.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de, linux-kernel@vger.kernel.org |
| X-Original-Date | Tue, 22 Sep 2015 17:08:50 -0700 |
| X-Original-Message-ID | <20150922170850.d46e58d9.akpm@linux-foundation.org> |
| X-Original-References | <1442922494-5677-1-git-send-email-bhe@redhat.com> <20150922125410.c7b4e8f47ee7fdf1147e2fa0@linux-foundation.org> <20150923000255.GA2569@dhcp-17-102.nay.redhat.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1231058 |
Show key headers only | View raw
On Wed, 23 Sep 2015 08:02:55 +0800 Baoquan He <bhe@redhat.com> wrote:
> >
> > > }
> > >
> > > low_base = memblock_find_in_range(low_size, (1ULL<<32),
> > > low_size, alignment);
> > >
> > > if (!low_base) {
> > > - if (!auto_set)
> > > - pr_info("crashkernel low reservation failed - No suitable area found.\n");
> > > -
> > > - return;
> > > + pr_info("crashkernel low reservation failed - No suitable area found.\n");
> >
> > That's not a terribly useful message. If kdump is now unavailable and
> > the operator needs to take some remedial action then we should inform
> > them of this.
> >
> > Also, such a message should have higher severity than KERN_INFO?
>
> Yes, how about KERN_ERR? It's an unexpected result from kdump side
> though it doesn't harm the normal kernel.
Sure, KERN_ERR is good. Along with more useful message text.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-22 13:50 +0200
Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-22 16:00 +0200
Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Andrew Morton <akpm@linux-foundation.org> - 2015-09-22 22:00 +0200
Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-23 02:10 +0200
Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Andrew Morton <akpm@linux-foundation.org> - 2015-09-23 02:10 +0200
Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-23 02:30 +0200
csiph-web