Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Baoquan He <bhe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
Date	Wed, 23 Sep 2015 02:10:01 +0200
Message-ID	<qbFNf-4eK-11@gated-at.bofh.it> (permalink)
References	<qbuf8-4hk-15@gated-at.bofh.it> <qbBTk-6Qf-23@gated-at.bofh.it>
X-Original-To	Andrew Morton <akpm@linux-foundation.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.27
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	55
Organization	linux.* mail to news gateway
X-Original-Cc	yinghai@kernel.org, dyoung@redhat.com, jroedel@suse.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 23 Sep 2015 08:02:55 +0800
X-Original-Message-ID	<20150923000255.GA2569@dhcp-17-102.nay.redhat.com>
X-Original-References	<1442922494-5677-1-git-send-email-bhe@redhat.com> <20150922125410.c7b4e8f47ee7fdf1147e2fa0@linux-foundation.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1231055

Show key headers only | View raw

On 09/22/15 at 12:54pm, Andrew Morton wrote:
> > --- a/arch/x86/kernel/setup.c
> > +++ b/arch/x86/kernel/setup.c
> > @@ -493,7 +493,7 @@ static void __init memblock_x86_reserve_range_setup_data(void)
> >  # define CRASH_KERNEL_ADDR_HIGH_MAX	MAXMEM
> >  #endif
> >  
> > -static void __init reserve_crashkernel_low(void)
> > +static int __init reserve_crashkernel_low(void)
> >  {
> >  #ifdef CONFIG_X86_64
> >  	const unsigned long long alignment = 16<<20;	/* 16M */
> > @@ -522,17 +522,15 @@ static void __init reserve_crashkernel_low(void)
> >  	} else {
> >  		/* passed with crashkernel=0,low ? */
> >  		if (!low_size)
> > -			return;
> > +			return 0;
> 
> What's happening here?  It's returning "success" when
> parse_crashkernel_low() fails?

It's the case user specify "crashkernel=0,low" to disable
crashkernel low memory allocation explicitly. So here we parse the
cmdline and get it's in this case, reture 0 directly.

> 
> >  	}
> >  
> >  	low_base = memblock_find_in_range(low_size, (1ULL<<32),
> >  					low_size, alignment);
> >  
> >  	if (!low_base) {
> > -		if (!auto_set)
> > -			pr_info("crashkernel low reservation failed - No suitable area found.\n");
> > -
> > -		return;
> > +		pr_info("crashkernel low reservation failed - No suitable area found.\n");
> 
> That's not a terribly useful message.  If kdump is now unavailable and
> the operator needs to take some remedial action then we should inform
> them of this.
> 
> Also, such a message should have higher severity than KERN_INFO?

Yes, how about KERN_ERR? It's an unexpected result from kdump side
though it doesn't harm the normal kernel.


> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-22 13:50 +0200
  Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel  low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-22 16:00 +0200
  Re: [Patch v4] Do not reserve crashkernel high memory if  crashkernel low memory reserving failed Andrew Morton <akpm@linux-foundation.org> - 2015-09-22 22:00 +0200
    Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel  low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-23 02:10 +0200
      Re: [Patch v4] Do not reserve crashkernel high memory if  crashkernel low memory reserving failed Andrew Morton <akpm@linux-foundation.org> - 2015-09-23 02:10 +0200
        Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel  low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-23 02:30 +0200

csiph-web