Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1230963

Re: [PATCH 2/3] usb: gadget: f_midi: free usb request when done

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Sep 22, 2015 at 07:59:09PM +0100, Felipe F. Tonello wrote:
> req->actual == req->length means that there is no data left to enqueue,
> so free the request.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>  drivers/usb/gadget/function/f_midi.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index edb84ca..e92aff5 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -258,7 +258,10 @@ f_midi_complete(struct usb_ep *ep, struct usb_request *req)
>  		} else if (ep == midi->in_ep) {
>  			/* Our transmit completed. See if there's more to go.
>  			 * f_midi_transmit eats req, don't queue it again. */
> -			f_midi_transmit(midi, req);
> +			if (req->actual < req->length)
> +				f_midi_transmit(midi, req);
> +			else
> +				free_ep_req(ep, req);

I'd have to have a deeper look at f_midi, but this doesn't look
correct to me. Why do you think that we should stop queueing
requests when we transfer one in full ?

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] usb: gadget: f_midi: free usb request when done "Felipe F. Tonello" <eu@felipetonello.com> - 2015-09-22 21:10 +0200
  Re: [PATCH 2/3] usb: gadget: f_midi: free usb request when done Felipe Balbi <balbi@ti.com> - 2015-09-22 23:20 +0200
  Re: [PATCH 2/3] usb: gadget: f_midi: free usb request when done Felipe Tonello <eu@felipetonello.com> - 2015-09-23 13:50 +0200
    Re: [PATCH 2/3] usb: gadget: f_midi: free usb request when done Alan Stern <stern@rowland.harvard.edu> - 2015-09-23 16:40 +0200
      Re: [PATCH 2/3] usb: gadget: f_midi: free usb request when done Felipe Tonello <eu@felipetonello.com> - 2015-09-23 16:50 +0200

csiph-web