Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1230776

[PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails

Show all headers | View raw

This fix a memory leak that will occur in this case.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 drivers/usb/gadget/function/f_midi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index e92aff5..e6a114b 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -550,9 +550,11 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
 		int err;
 
 		err = usb_ep_queue(ep, req, GFP_ATOMIC);
-		if (err < 0)
+		if (err < 0) {
 			ERROR(midi, "%s queue req: %d\n",
 			      midi->in_ep->name, err);
+			free_ep_req(ep, req);
+		}
 	} else {
 		free_ep_req(ep, req);
 	}
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails "Felipe F. Tonello" <eu@felipetonello.com> - 2015-09-22 21:00 +0200
  Re: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue  fails Felipe Balbi <balbi@ti.com> - 2015-09-22 23:20 +0200
  Re: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails Felipe Tonello <eu@felipetonello.com> - 2015-09-23 13:50 +0200
    Re: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails Felipe Tonello <eu@felipetonello.com> - 2015-09-25 10:30 +0200
      Re: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails Felipe Tonello <eu@felipetonello.com> - 2015-09-25 12:30 +0200

csiph-web