Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for cpu hotplug

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for cpu hotplug
Date	2015-09-22 21:00 +0200
Message-ID	<qbAXg-5tC-39@gated-at.bofh.it> (permalink)
References	<qagHf-5Gn-3@gated-at.bofh.it> <qagHf-5Gn-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 19 Sep 2015, Yang Yingliang wrote:

> Add irq_migrate_all_off_this_cpu() into kernel/irq/migration.c.

This doesn't make any sense at all. 

You just reuse the existing file to stick your new code into it
without reusing a single bit in that file. Aside of that it's
unconditionally compiled, which means all existing users of
CONFIG_GENERIC_PENDING_IRQ are burdened with pointless code.

The right thing to do is:

Add that code to a new file: kernel/irq/cpuhotplug.c and make that
depend on CONFIG_GENERIC_IRQ_MIGRATION.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu()  for cpu hotplug Thomas Gleixner <tglx@linutronix.de> - 2015-09-22 21:00 +0200
  Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for  cpu hotplug Yang Yingliang <yangyingliang@huawei.com> - 2015-09-23 06:20 +0200
    Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu()  for cpu hotplug Thomas Gleixner <tglx@linutronix.de> - 2015-09-23 10:10 +0200

csiph-web