Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1230779

Re: [PATCH] x86/mm: Export cpu_tlbstate as non-GPL symbol

From Andy Lutomirski <luto@amacapital.net>
Newsgroups linux.kernel
Subject Re: [PATCH] x86/mm: Export cpu_tlbstate as non-GPL symbol
Date 2015-09-22 21:00 +0200
Message-ID <qbAXg-5tC-15@gated-at.bofh.it> (permalink)
References <qbAXg-5tC-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Sep 22, 2015 at 11:51 AM, James Forcier <csssuf@csssuf.net> wrote:
> Exporting cpu_tlbstate as a GPL symbol was introduced in 1e02ce4c; however, this
> breaks non-GPL modules which need to link against it, particularly the AMD
> Catalyst drivers.

What is AMD Catalyst doing with cpu_tlbstate?

--Andy

>
> Signed-off-by: James Forcier <csssuf@csssuf.net>
> ---
>  arch/x86/mm/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index 1d8a83d..94be56b 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -742,7 +742,7 @@ DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) = {
>  #endif
>         .cr4 = ~0UL,    /* fail hard if we screw up cr4 shadow initialization */
>  };
> -EXPORT_SYMBOL_GPL(cpu_tlbstate);
> +EXPORT_SYMBOL(cpu_tlbstate);
>
>  void update_cache_mode_entry(unsigned entry, enum page_cache_mode cache)
>  {
> --
> 2.4.6
>



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] x86/mm: Export cpu_tlbstate as non-GPL symbol Andy Lutomirski <luto@amacapital.net> - 2015-09-22 21:00 +0200

csiph-web