Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1230722

Re: [RFC v2 04/18] kthread: Add destroy_kthread_worker()

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [RFC v2 04/18] kthread: Add destroy_kthread_worker()
Date 2015-09-22 20:40 +0200
Message-ID <qbADW-561-77@gated-at.bofh.it> (permalink)
References <qb910-7vU-15@gated-at.bofh.it> <qb913-7vU-75@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello,

On Mon, Sep 21, 2015 at 03:03:45PM +0200, Petr Mladek wrote:
...
> Note that flush() does not guarantee that the queue is empty. drain()
> is more safe. It returns when the queue is really empty. Also it warns

Maybe it'd be better to be a bit more specific.  drain() is safer
because it can handle self-requeueing work items.

> when too many work is being queued when draining.
...
> +/**
> + * destroy_kthread_worker - destroy a kthread worker
> + * @worker: worker to be destroyed
> + *
> + * Destroy @worker. It should be idle when this is called.

So, no new work item should be queued from this point on but @worker
is allowed to be not idle.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [RFC v2 04/18] kthread: Add destroy_kthread_worker() Tejun Heo <tj@kernel.org> - 2015-09-22 20:40 +0200

csiph-web