Re: [PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver

From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver
Date	2015-09-22 20:40 +0200
Message-ID	<qbADU-561-25@gated-at.bofh.it> (permalink)
References	<qbAug-4UA-57@gated-at.bofh.it> <qbADU-561-27@gated-at.bofh.it>
Organization	ARM Ltd

Show all headers | View raw

On Mon, 21 Sep 2015 10:13:04 +0800
Ley Foon Tan <lftan@altera.com> wrote:

> This patch adds the Altera PCIe host controller driver.
> 
> Signed-off-by: Ley Foon Tan <lftan@altera.com>
> ---
>  drivers/pci/host/Kconfig       |   8 +
>  drivers/pci/host/Makefile      |   1 +
>  drivers/pci/host/pcie-altera.c | 591 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 600 insertions(+)
>  create mode 100644 drivers/pci/host/pcie-altera.c
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index d5e58ba..df9ed4f 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -145,4 +145,12 @@ config PCIE_IPROC_BCMA
>  	  Say Y here if you want to use the Broadcom iProc PCIe controller
>  	  through the BCMA bus interface
>  
> +config PCIE_ALTERA
> +	tristate "Altera PCIe controller"
> +	depends on ARCH_SOCFPGA || NIOS2
> +	select PCI_DOMAINS
> +	help
> +	  Say Y here if you want to enable PCIe controller support for Altera
> +	  SoCFPGA family of SoCs.
> +

Is there anything in this driver that is actually specific to any of
these two platforms/architectures? I'd don't think we should restrict
if we can avoid it (hint: the companion MSI driver is not restricted to
any architecture).

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver Marc Zyngier <marc.zyngier@arm.com> - 2015-09-22 20:40 +0200
  Re: [PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver Ley Foon Tan <lftan@altera.com> - 2015-09-23 11:40 +0200
    Re: [PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver Marc Zyngier <marc.zyngier@arm.com> - 2015-09-23 17:20 +0200

csiph-web