[PATCH 13/38] ARM: shmobile: apmu: correct type of CPU id

From	Andrzej Hajda <a.hajda@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 13/38] ARM: shmobile: apmu: correct type of CPU id
Date	2015-09-21 16:00 +0200
Message-ID	<qb9No-8s4-21@gated-at.bofh.it> (permalink)
References	<qb9u2-83M-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

CPU id can be negative, so it cannot be assigned to unsigned variable.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 arch/arm/mach-shmobile/platsmp-apmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/platsmp-apmu.c b/arch/arm/mach-shmobile/platsmp-apmu.c
index 4e54512..292c67b 100644
--- a/arch/arm/mach-shmobile/platsmp-apmu.c
+++ b/arch/arm/mach-shmobile/platsmp-apmu.c
@@ -88,7 +88,7 @@ static void apmu_init_cpu(struct resource *res, int cpu, int bit)
 static void apmu_parse_cfg(void (*fn)(struct resource *res, int cpu, int bit),
 			   struct rcar_apmu_config *apmu_config, int num)
 {
-	u32 id;
+	int id;
 	int k;
 	int bit, index;
 	bool is_allowed;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 13/38] ARM: shmobile: apmu: correct type of CPU id Andrzej Hajda <a.hajda@samsung.com> - 2015-09-21 16:00 +0200

csiph-web