[PATCH 31/38] leds: tca6507: remove invalid check

From	Andrzej Hajda <a.hajda@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 31/38] leds: tca6507: remove invalid check
Date	2015-09-21 15:50 +0200
Message-ID	<qb9DI-8gq-7@gated-at.bofh.it> (permalink)
References	<qb9u2-83M-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

unsigned value cannot be lesser than zero.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/leds/leds-tca6507.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index edbecc4..93564f6 100644
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -713,7 +713,7 @@ tca6507_led_dt_init(struct i2c_client *client)
 		if (of_property_match_string(child, "compatible", "gpio") >= 0)
 			led.flags |= TCA6507_MAKE_GPIO;
 		ret = of_property_read_u32(child, "reg", &reg);
-		if (ret != 0 || reg < 0 || reg >= NUM_LEDS)
+		if (ret != 0 || reg >= NUM_LEDS)
 			continue;
 
 		tca_leds[reg] = led;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 31/38] leds: tca6507: remove invalid check Andrzej Hajda <a.hajda@samsung.com> - 2015-09-21 15:50 +0200
  Re: [PATCH 31/38] leds: tca6507: remove invalid check Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-09-22 09:40 +0200

csiph-web