Re: [PATCH 2/5] pinctrl: berlin: add the berlin4ct pinctrl driver

From	Jisheng Zhang <jszhang@marvell.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] pinctrl: berlin: add the berlin4ct pinctrl driver
Date	2015-09-21 14:20 +0200
Message-ID	<qb8eD-6lp-23@gated-at.bofh.it> (permalink)
References	<qanfH-6H6-5@gated-at.bofh.it> <qanfH-6H6-15@gated-at.bofh.it> <qaSCS-Qh-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dear Sebastian,

On Sun, 20 Sep 2015 21:32:37 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:

> > +	BERLIN_PINCTRL_GROUP("SM_TDO", 0x0, 0x3, 0x12,
> > +			BERLIN_PINCTRL_FUNCTION(0x0, "sm_tdo"),
> > +			BERLIN_PINCTRL_FUNCTION(0x1, "sm_gpio2")),
> > +	BERLIN_PINCTRL_GROUP("SM_URT0_TXD", 0x0, 0x3, 0x15,
> > +			BERLIN_PINCTRL_FUNCTION(0x0, "sm_urt0_txd"),  
> 
> Please avoid abbreviating acronyms even more, we can afford the
> few extra bytes.

In the 2nd version, I kept using HW names, for example:

1. "urt0" as the function name,

2. "SM_URT0_TXD" as the pin name (group name)

to keep sync with HW, especially the pin names are the same as HW's, because
that's what HW doc, sch, etc. call them. IMHO, using a different name with HW
is not a good idea, what do you think?

Thanks,
Jisheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] pinctrl: berlin: add the berlin4ct pinctrl driver Jisheng Zhang <jszhang@marvell.com> - 2015-09-19 12:10 +0200
  Re: [PATCH 2/5] pinctrl: berlin: add the berlin4ct pinctrl driver Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-09-20 21:40 +0200
    Re: [PATCH 2/5] pinctrl: berlin: add the berlin4ct pinctrl driver Jisheng Zhang <jszhang@marvell.com> - 2015-09-21 09:40 +0200
    Re: [PATCH 2/5] pinctrl: berlin: add the berlin4ct pinctrl driver Jisheng Zhang <jszhang@marvell.com> - 2015-09-21 14:20 +0200

csiph-web