Re: linux-next: build failure after merge of the akpm-current tree

From	Stephen Rothwell <sfr@canb.auug.org.au>
Newsgroups	linux.kernel
Subject	Re: linux-next: build failure after merge of the akpm-current tree
Date	2015-09-21 12:20 +0200
Message-ID	<qb6mt-3FW-1@gated-at.bofh.it> (permalink)
References	<qb0K5-449-13@gated-at.bofh.it> <qb4b0-nG-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Michal, Vladimir,

On Mon, 21 Sep 2015 09:58:53 +0200 Michal Hocko <mhocko@kernel.org> wrote:
>
> AFAIU your fix is correct but using
> cgroup_subsys_on_dfl(memory_cgrp_subsys) is more appropriate:
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index d62924ee8022..c3df03add73e 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -176,7 +176,7 @@ static bool sane_reclaim(struct scan_control *sc)
>  	if (!memcg)
>  		return true;
>  #ifdef CONFIG_CGROUP_WRITEBACK
> -	if (cgroup_on_dfl(memcg->css.cgroup))
> +	if (cgroup_subsys_on_dfl(memory_cgrp_subsys))
>  		return true;
>  #endif
>  	return false;

Thanks, I will do that from tomorrow.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-09-21 06:20 +0200
  Re: linux-next: build failure after merge of the akpm-current tree Vladimir Davydov <vdavydov@parallels.com> - 2015-09-21 10:00 +0200
  Re: linux-next: build failure after merge of the akpm-current tree Michal Hocko <mhocko@kernel.org> - 2015-09-21 10:00 +0200
    Re: linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-09-21 12:20 +0200

csiph-web