Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API
Date	2015-09-21 10:00 +0200
Message-ID	<qb4b0-nG-9@gated-at.bofh.it> (permalink)
References	<q9Wfw-1oJ-7@gated-at.bofh.it> <q9Wpd-1zU-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (09/18/15 14:19), Joonsoo Kim wrote:
[..]
> +	/*
> +	 * Prepare to use crypto decompress_noctx API. One tfm is required
> +	 * to initialize crypto algorithm properly and fetch corresponding
> +	 * function pointer. But, it is sharable for multiple concurrent
> +	 * decompress users.
> +	 */

if comp algorithm require zstrm for both compression and decompression,
then there seems to be no need in allocating sharable ->tfm_noctx, we
will never use it.

	-ss

> +	tfm = crypto_alloc_comp_noctx(compress, 0, 0);
> +	if (!IS_ERR(tfm))
> +		comp->tfm_noctx = tfm;
> +
>  	return comp;
>  }
> diff --git a/drivers/block/zram/zcomp.h b/drivers/block/zram/zcomp.h
> index 4f9df8e..c76d8e4 100644
> --- a/drivers/block/zram/zcomp.h
> +++ b/drivers/block/zram/zcomp.h
> @@ -26,6 +26,7 @@ struct zcomp_strm {
>  /* dynamic per-device compression frontend */
>  struct zcomp {
>  	void *stream;
> +	struct crypto_comp *tfm_noctx;
>  	const char *backend;
>  
>  	struct zcomp_strm *(*strm_find)(struct zcomp *comp);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 0/9] zram: introduce crypto decompress noctx API and use it on zram Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:20 +0200
  [PATCH v3 4/9] crypto/lz4hc: support decompress_noctx Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:30 +0200
  [PATCH v3 3/9] crypyo/lz4: support decompress_noctx Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:30 +0200
  [PATCH v3 8/9] zram: use crypto API for compression Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:30 +0200
    Re: [PATCH v3 8/9] zram: use crypto API for compression Minchan Kim <minchan@kernel.org> - 2015-09-21 05:50 +0200
    Re: [PATCH v3 8/9] zram: use crypto API for compression Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-21 07:20 +0200
  [PATCH v3 6/9] zram: make stream find and release functions static Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:30 +0200
    Re: [PATCH v3 6/9] zram: make stream find and release functions  static Minchan Kim <minchan@kernel.org> - 2015-09-21 01:40 +0200
  [PATCH v3 2/9] crypto/lzo: support decompress_noctx Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:30 +0200
  [PATCH v3 5/9] crypto/842: support decompress_noctx Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:30 +0200
  [PATCH v3 7/9] zram: pass zstrm down to decompression path Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:30 +0200
    Re: [PATCH v3 7/9] zram: pass zstrm down to decompression path Minchan Kim <minchan@kernel.org> - 2015-09-21 01:50 +0200
  [PATCH v3 9/9] zram: use crypto decompress_noctx API Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:30 +0200
    Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API Minchan Kim <minchan@kernel.org> - 2015-09-21 06:00 +0200
    Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-21 07:30 +0200
    Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-21 10:00 +0200
  [PATCH v3 1/9] crypto: introduce decompression API that can be called via sharable tfm object Joonsoo Kim <js1304@gmail.com> - 2015-09-18 07:30 +0200
    Re: [PATCH v3 1/9] crypto: introduce decompression API that can be  called via sharable tfm object Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-21 07:40 +0200
    Re: [PATCH v3 1/9] crypto: introduce decompression API that can be  called via sharable tfm object Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-21 08:20 +0200
  Re: [PATCH v3 0/9] zram: introduce crypto decompress noctx API and  use it on zram Minchan Kim <minchan@kernel.org> - 2015-09-21 06:00 +0200
  [RFC][PATCH 1/9] crypto: introduce CRYPTO_ALG_TFM_MAY_SHARE flag Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:20 +0200
  [RFC][PATCH 6/9] zram: make stream find and release functions static Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:20 +0200
  [RFC][PATCH 3/9] crypto/lz4: set CRYPTO_ALG_TFM_MAY_SHARE Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:20 +0200
  [RFC][PATCH 5/9] crypto/842: set CRYPTO_ALG_TFM_MAY_SHARE Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:20 +0200
  [RFC][PATCH 0/9] use CRYPTO_ALG_TFM_MAY_SHARE cra flag (full patchset) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:20 +0200
    [RFC][PATCH 4/9] crypto/lz4hc: set CRYPTO_ALG_TFM_MAY_SHARE Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:20 +0200
    [RFC][PATCH 2/9] crypto/lzo: set CRYPTO_ALG_TFM_MAY_SHARE Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:20 +0200
    [RFC][PATCH 7/9] zram: pass zstrm down to decompression path Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:20 +0200
    [RFC][PATCH 9/9] zram: use crypto CRYPTO_ALG_TFM_MAY_SHARE API Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:30 +0200
    Re: [RFC][PATCH 0/9] use CRYPTO_ALG_TFM_MAY_SHARE cra flag (full  patchset) Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:30 +0200
    [RFC][PATCH 8/9] zram: use crypto API for compression Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-21 15:50 +0200

csiph-web