Re: [PATCH 1/3] avr32: fix build failure

From	Hans-Christian Egtvedt <egtvedt@samfundet.no>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] avr32: fix build failure
Date	2015-09-21 09:40 +0200
Message-ID	<qb3RE-8sg-9@gated-at.bofh.it> (permalink)
References	<qatXQ-7P2-7@gated-at.bofh.it> <qatXQ-7P2-9@gated-at.bofh.it> <qb2sy-6Ac-19@gated-at.bofh.it> <qb2VA-77F-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Around Mon 21 Sep 2015 12:09:01 +0530 or thereabout, Sudip Mukherjee wrote:
> On Mon, Sep 21, 2015 at 08:09:42AM +0200, Hans-Christian Egtvedt wrote:
>> Around Sat 19 Sep 2015 22:42:57 +0530 or thereabout, Sudip Mukherjee wrote:
>> > While building avr32 with allmodconfig, the build used to fail with the
>> > message:
>> > error: implicit declaration of function 'pci_iomap'
>> > error: implicit declaration of function 'pci_iounmap'
>> 
>> What has changed recently that start pulling in these? AVR32 does not have
>> PCI at all, and will never have it either. Is this exposing a bug somewhere
>> else?
> It looks like pci_iomap and pci_iounmap doesnot depend on CONFIG_PCI.
> So drivers/net/ethernet/via/via-rhine.c is calling these functions even
> if PCI is disabled. The build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/81127188
> 
> You can find a similar discussion at:
> http://www.linux-mips.org/archives/linux-mips/2013-06/msg00510.html

If multiple architectures have similar problems, then a more global
definition of these unused functions could be added.

Just move the implementation for MIPS into include/asm-generic/io.h ?

That way we do not have to implement and identical stub for every device not
supporting PCI.

-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/3] avr32: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-19 19:20 +0200
  Re: [PATCH 1/3] avr32: fix build failure Hans-Christian Egtvedt <egtvedt@samfundet.no> - 2015-09-21 08:10 +0200
    Re: [PATCH 1/3] avr32: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-21 08:40 +0200
      Re: [PATCH 1/3] avr32: fix build failure Hans-Christian Egtvedt <egtvedt@samfundet.no> - 2015-09-21 09:40 +0200
        Re: [PATCH 1/3] avr32: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-21 10:10 +0200

csiph-web