Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1229054

Re: [PATCH] macvtap: fix TUNSETSNDBUF values > 64k

Show all headers | View raw

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Fri, 18 Sep 2015 13:41:09 +0300

> Upon TUNSETSNDBUF,  macvtap reads the requested sndbuf size into
> a local variable u.
> commit 39ec7de7092b ("macvtap: fix uninitialized access on
> TUNSETIFF") changed its type to u16 (which is the right thing to
> do for all other macvtap ioctls), breaking all values > 64k.
> 
> The value of TUNSETSNDBUF is actually a signed 32 bit integer, so
> the right thing to do is to read it into an int.
> 
> Cc: David S. Miller <davem@davemloft.net>
> Fixes: 39ec7de7092b ("macvtap: fix uninitialized access on TUNSETIFF")
> Reported-by: Mark A. Peloquin
> Bisected-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] macvtap: fix TUNSETSNDBUF values > 64k "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-18 12:50 +0200
  Re: [PATCH] macvtap: fix TUNSETSNDBUF values > 64k Christian Borntraeger <borntraeger@de.ibm.com> - 2015-09-18 12:50 +0200
    Re: [PATCH] macvtap: fix TUNSETSNDBUF values > 64k "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-18 13:00 +0200
  Re: [PATCH] macvtap: fix TUNSETSNDBUF values > 64k David Miller <davem@davemloft.net> - 2015-09-21 07:50 +0200

csiph-web