Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1228476

[PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

From Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency
Date 2015-09-19 19:20 +0200
Message-ID <qatXQ-7P2-5@gated-at.bofh.it> (permalink)
References <qatXQ-7P2-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


While building allmodconfig on avr32 the build failed with the error:
"at91_pmc_base" [drivers/usb/gadget/udc/atmel_usba_udc.ko] undefined!

On checking the code it turned out that if CONFIG_OF is defined then it
is using at91_pmc_read() which is using at91_pmc_base. And unless
COMMON_CLK_AT91 is defined we donot have at91_pmc_base. And
COMMON_CLK_AT91 is available with AT91 architecture.
Mention the dependency such that this driver builds with avr32 only if
OF is not enabled.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

Tested build with at91_dt_defconfig and allmodconfig of avr32. Build log
at:
https://travis-ci.org/sudipm-mukherjee/parport/builds/81168845

 drivers/usb/gadget/udc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
index 9a3a6b0..cdbff54 100644
--- a/drivers/usb/gadget/udc/Kconfig
+++ b/drivers/usb/gadget/udc/Kconfig
@@ -55,7 +55,7 @@ config USB_LPC32XX
 
 config USB_ATMEL_USBA
 	tristate "Atmel USBA"
-	depends on AVR32 || ARCH_AT91
+	depends on ((AVR32 && !OF) || ARCH_AT91)
 	help
 	  USBA is the integrated high-speed USB Device controller on
 	  the AT32AP700x, some AT91SAM9 and AT91CAP9 processors from Atmel.
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] usb: gadget: at91_udc: mention proper dependency Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-19 19:20 +0200
  Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency Felipe Balbi <balbi@ti.com> - 2015-09-20 18:20 +0200
    Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-21 13:20 +0200

csiph-web