Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228393

Re: [PATCH] staging: lustre: lustre: lclient: Removed the else statement

Show all headers | View raw

On Thu, Sep 17, 2015 at 09:44:41PM +0530, Anjali Menon wrote:
> Removed the else statement along with some unwanted brackets
> to fix the following coding style warning detected by
> checkpatch.
> 
> WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
>  drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> index ab6cb41..23092fc 100644
> --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> @@ -836,7 +836,7 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
>  					*exceed = 1;
>  			}
>  			return result;
> -		} else {
> +		}
>  			/*
>  			 * region is within kms and, hence, within real file
>  			 * size (A). We need to increase i_size to cover the

This change isn't correct, look at how the code now looks :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: lustre: lclient: Removed the else statement Anjali Menon <cse.anjalimenon@gmail.com> - 2015-09-17 18:20 +0200
  Re: [PATCH] staging: lustre: lustre: lclient: Removed the else statement Jaime Arrocha <jarr@innercoder.com> - 2015-09-17 19:00 +0200
  Re: [PATCH] staging: lustre: lustre: lclient: Removed the else  statement Greg KH <gregkh@linuxfoundation.org> - 2015-09-19 07:10 +0200

csiph-web