Re: [Ksummit-discuss] 2038 Kernel Summit Discussion Fodder

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	"H. Peter Anvin" <hpa@zytor.com>
Newsgroups	linux.kernel
Subject	Re: [Ksummit-discuss] 2038 Kernel Summit Discussion Fodder
Date	Sat, 19 Sep 2015 02:10:02 +0200
Message-ID	<qadT4-1Db-9@gated-at.bofh.it> (permalink)
References	<nOwaK-4T4-13@gated-at.bofh.it> <nOwaK-4T4-11@gated-at.bofh.it> <nON1U-5NY-17@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>, ksummit-discuss@lists.linuxfoundation.org
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	Ben Hutchings <ben@decadent.org.uk>, John Stultz <john.stultz@linaro.org>, "Joseph S. Myers" <joseph@codesourcery.com>, lkml <linux-kernel@vger.kernel.org>
X-Original-Date	Fri, 18 Sep 2015 17:04:22 -0700
X-Original-Message-ID	<55FCA686.601@zytor.com>
X-Original-References	<CALAqxLUcfaJnxdmkn6mucepNk3QaCQdcSPLRjjeKsk_OTp=uLA@mail.gmail.com> <1407895613.3017.138.camel@deadeye.wl.decadent.org.uk> <3758173.O0N9ZgmMoN@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1228352

Show key headers only | View raw

On 08/13/2014 01:06 PM, Arnd Bergmann wrote:
> On Wednesday 13 August 2014 03:06:53 Ben Hutchings wrote:
>>> On the kernel side, it also adds more complexity, where we have to add
>>> even more complex compat support for 64bit systems to handle all the
>>> various 32bit applications possible.
>> [...]
>>
>> Didn't we need to do this already to support x32?  Have compat ioctls
>> involving time been botched?
> 
> AFAICT, every ioctl that involves passing a __kernel_ulong_t or
> __kernel_ulong_t is potentially broken on x32, and this includes
> everything passing a time_t or timespec.
> 
> The problem is that the libc ioctl() function ends up in the kernel's
> compat_ioctl handler, which expects the 32-bit ABI, not the 64-bit ABI.
> Most other syscalls in x32 however use the 64-bit ABI.
> 
> It works only for drivers that use the same function for .ioctl and
> .compat_ioctl, and that encode the size of the data structure correctly
> in the ioctl command code. I assume this is how we will do it for all
> 32-bit architectures with 64-bit time_t, but on x32 it also concerns
> other types that use __kernel_long_t.
> 

OK, super-late reply.

Actually we have by and large dealt with that.  Sadly this meant an
increase in the number of paths with conditional ABI.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Ksummit-discuss] 2038 Kernel Summit Discussion Fodder "H. Peter Anvin" <hpa@zytor.com> - 2015-09-19 02:10 +0200

csiph-web