Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228333

Re: [PATCH 2/2] drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty()

Show all headers | View raw

Reviewed-by: Sinclair Yeh <syeh@vmware.com>

On Sat, Sep 19, 2015 at 12:32:24AM +0200, Christian Engelmayer wrote:
> Function vmw_kms_helper_dirty() uses the uninitialized variable ret as
> return value. Make the result deterministic and directly return as the
> variable is unused anyway. Detected by Coverity CID 1324255.
> 
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Compile tested only. Applies against linux-next.
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 61fb7f3de311..15a6c01cd016 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -1685,7 +1685,6 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
>  	struct drm_crtc *crtc;
>  	u32 num_units = 0;
>  	u32 i, k;
> -	int ret;
>  
>  	dirty->dev_priv = dev_priv;
>  
> @@ -1711,7 +1710,7 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
>  			if (!dirty->cmd) {
>  				DRM_ERROR("Couldn't reserve fifo space "
>  					  "for dirty blits.\n");
> -				return ret;
> +				return -ENOMEM;
>  			}
>  			memset(dirty->cmd, 0, dirty->fifo_reserve_size);
>  		}
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty() Christian Engelmayer <cengelma@gmx.at> - 2015-09-19 00:40 +0200
  Re: [PATCH 2/2] drm/vmwgfx: Fix uninitialized return in  vmw_kms_helper_dirty() "Sinclair Yeh" <syeh@vmware.com> - 2015-09-19 00:50 +0200

csiph-web