Re: [PATCH RESEND 1/2] arm: berlin: use non-self-cleared reset register to reset cpu

Path	csiph.com!goblin3!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Jisheng Zhang <jszhang@marvell.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 1/2] arm: berlin: use non-self-cleared reset register to reset cpu
Date	Mon, 21 Sep 2015 04:30:02 +0200
Message-ID	<qaZ1E-1Bl-5@gated-at.bofh.it> (permalink)
References	<q8vU5-70S-9@gated-at.bofh.it> <q8vU5-70S-7@gated-at.bofh.it> <qaRdM-7oP-17@gated-at.bofh.it>
X-Original-To	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
X-Mailer	Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset="US-ASCII"
Content-Transfer-Encoding	7bit
X-Proofpoint-Virus-Version	vendor=fsecure engine=2.50.10432:,, definitions=2015-09-21_01:,, signatures=0
X-Proofpoint-Spam-Details	rule=inbound_notspam policy=inbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1509210039
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	66
Organization	linux.* mail to news gateway
X-Original-Cc	<linux@arm.linux.org.uk>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 21 Sep 2015 10:18:25 +0800
X-Original-Message-ID	<20150921101825.099b304f@xhacker>
X-Original-References	<1442213265-1002-1-git-send-email-jszhang@marvell.com> <1442213265-1002-2-git-send-email-jszhang@marvell.com> <55FEF511.2050600@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1228998

Show key headers only | View raw

Dear Sebastian,

On Sun, 20 Sep 2015 20:04:01 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:

> On 14.09.2015 08:47, Jisheng Zhang wrote:
> > In Berlin SoCs, there are two kinds of cpu reset control registers: the
> > first one's corresponding bits will be self-cleared after some cycles,
> > while the second one's bits won't. Previously the first kind of reset
> > control register is used, this patch uses the second kind one to prepare
> > for the next hotplug commit.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > ---
> >   arch/arm/mach-berlin/platsmp.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-berlin/platsmp.c b/arch/arm/mach-berlin/platsmp.c
> > index 34a3753..bde327b 100644
> > --- a/arch/arm/mach-berlin/platsmp.c
> > +++ b/arch/arm/mach-berlin/platsmp.c
> > @@ -17,7 +17,7 @@
> >   #include <asm/smp_plat.h>
> >   #include <asm/smp_scu.h>
> >
> > -#define CPU_RESET		0x00
> > +#define CPU_RESET		0x20
> 
> Jisheng,
> 
> I am fine with the patch itself, except that I'd like to rather
> rename the 0x00-register to CPU_RESET_SC with a comment about
> the self-clearing nature. The 0x20-register would then be named
> CPU_RESET_NON_SC and used the way you propose.

Good idea. And such comment would let people understand why do we change
as that.

> 
> Are you fine with me naming the registers accordingly while
> applying the patches?

Sure, I'm fine. Thank you very much.

> 
> Sebastian
> 
> >   #define RESET_VECT		0x00
> >   #define SW_RESET_ADDR		0x94
> > @@ -31,6 +31,8 @@ static inline void berlin_perform_reset_cpu(unsigned int cpu)
> >   	u32 val;
> >
> >   	val = readl(cpu_ctrl + CPU_RESET);
> > +	val &= ~BIT(cpu_logical_map(cpu));
> > +	writel(val, cpu_ctrl + CPU_RESET);
> >   	val |= BIT(cpu_logical_map(cpu));
> >   	writel(val, cpu_ctrl + CPU_RESET);
> >   }
> >
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 1/2] arm: berlin: use non-self-cleared reset register to reset cpu Jisheng Zhang <jszhang@marvell.com> - 2015-09-14 09:00 +0200
  Re: [PATCH RESEND 1/2] arm: berlin: use non-self-cleared reset register  to reset cpu Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-09-20 20:10 +0200
    Re: [PATCH RESEND 1/2] arm: berlin: use non-self-cleared reset  register to reset cpu Jisheng Zhang <jszhang@marvell.com> - 2015-09-21 04:30 +0200

csiph-web