Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228988

Re: Please suggest proper format for DT properties.

Show all headers | View raw

On Fri, Sep 18, 2015 at 5:36 PM, Constantine Shulyupin
<const@makelinux.com> wrote:
> Hi,
>
> I am designing DT support for a hwmon chip.
> It has some sensors, each of them can be:
>  - "disabled"
>  - "thermal diode"
>  - "thermistor"
>  - "voltage"
>
> Four possible options for DT properties format.
>
> Option 1: Separated property for each sensor.
>
> Example nct7802 node:
>
> nct7802 {
>         compatible = "nuvoton,nct7802";
>         reg = <0x2a>;
>         nuvoton,sensor1-type = "thermistor";
>         nuvoton,sensor2-type = "disabled";
>         nuvoton,sensor3-type = "voltage";
> };
>
> Option 2: Array of strings for all sensors.
>
> nct7802 {
>         compatible = "nuvoton,nct7802";
>         reg = <0x2a>;
>         nuvoton,sensors-types = "thermistor", "disabled", "voltage";
> };

It seems you are just listing out all possible modes. Why do you need
this in the DT at all? This can be inferred by the compatible string.

>
> Option 3: Sets of 4 cells.
>
>   Borrowed from marvell,reg-init and broadcom,c45-reg-init.
>
>   The first cell is the page address,
>   the second a register address within the page,
>   the third cell contains a mask to be ANDed with the existing register
>   value, and the fourth cell is ORed with the result to yield the
>   new register value. If the third cell has a value of zero,
>   no read of the existing value is performed.

I don't see how this relates to the first 2 options. The register you
write selects the mode? In general, we don't want bindings of just
random register writes.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Please suggest proper format for DT properties. Constantine Shulyupin <const@MakeLinux.com> - 2015-09-19 00:40 +0200
  Re: Please suggest proper format for DT properties. Rob Herring <robh@kernel.org> - 2015-09-21 04:00 +0200
    Re: Please suggest proper format for DT properties. Constantine Shulyupin <const@makelinux.com> - 2015-09-21 21:30 +0200
      Re: Please suggest proper format for DT properties. Rob Herring <robh@kernel.org> - 2015-09-22 02:40 +0200
  Re: Please suggest proper format for DT properties. Arnd Bergmann <arnd@arndb.de> - 2015-09-22 10:40 +0200

csiph-web