Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228951

[PATCH 8/9] staging: rtl8192e: Simplify _rtl92e_calculate_bit_shift

Show all headers | View raw

Use ffs instead of iteration. Behaviour of function doesn't change.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index b3a10f9..0b407fe 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -13,6 +13,7 @@
  * wlanfae <wlanfae@realtek.com>
 ******************************************************************************/
 
+#include <linux/bitops.h>
 #include "rtl_core.h"
 #include "r8192E_hw.h"
 #include "r8192E_phyreg.h"
@@ -50,13 +51,9 @@ static void _rtl92e_phy_rf_fw_write(struct net_device *dev,
 
 static u32 _rtl92e_calculate_bit_shift(u32 dwBitMask)
 {
-	u32 i;
-
-	for (i = 0; i <= 31; i++) {
-		if (((dwBitMask >> i) & 0x1) == 1)
-			break;
-	}
-	return i;
+	if (!dwBitMask)
+		return 32;
+	return ffs(dwBitMask) - 1;
 }
 
 u8 rtl92e_is_legal_rf_path(struct net_device *dev, u32 eRFPath)
-- 
1.8.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] staging: rtl8192e: Various cleanups Mateusz Kulikowski <mateusz.kulikowski@gmail.com> - 2015-09-20 21:10 +0200
  [PATCH 5/9] staging: rtl8192e: Remove _rtl92e_silent_reset_mesh Mateusz Kulikowski <mateusz.kulikowski@gmail.com> - 2015-09-20 21:10 +0200
  [PATCH 6/9] staging: rtl8192e: Remove _rtl92e_dm_check_pbc_gpio Mateusz Kulikowski <mateusz.kulikowski@gmail.com> - 2015-09-20 21:10 +0200
  [PATCH 9/9] staging: rtl8192e: Merge/Remove _rtl92e_dm_bb_initialgain_backup Mateusz Kulikowski <mateusz.kulikowski@gmail.com> - 2015-09-20 21:10 +0200
  [PATCH 8/9] staging: rtl8192e: Simplify _rtl92e_calculate_bit_shift Mateusz Kulikowski <mateusz.kulikowski@gmail.com> - 2015-09-20 21:10 +0200
  [PATCH 1/9] staging: rtl8192e: rtl_wx: Fix BRACES warning Mateusz Kulikowski <mateusz.kulikowski@gmail.com> - 2015-09-20 21:10 +0200
  [PATCH 4/9] staging: rtl8192e: Fix FSF_MAILING_ADDRESS warnings Mateusz Kulikowski <mateusz.kulikowski@gmail.com> - 2015-09-20 21:10 +0200

csiph-web