Re: [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW and DC5LDO regulators

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW and DC5LDO regulators
Date	Sun, 20 Sep 2015 12:20:02 +0200
Message-ID	<qaJSW-5lZ-9@gated-at.bofh.it> (permalink)
References	<q9bgC-gD-3@gated-at.bofh.it> <q9bgC-gD-13@gated-at.bofh.it> <qaEgy-5MM-19@gated-at.bofh.it>
X-Original-To	Lee Jones <lee.jones@linaro.org>
X-Received	by 10.50.50.143 with SMTP id c15mr966924igo.36.1442744273625; Sun, 20 Sep 2015 03:17:53 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	8BIT
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	69
Organization	linux.* mail to news gateway
X-Original-Cc	Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Russell King <linux@arm.linux.org.uk>, Maxime Ripard <maxime.ripard@free-electrons.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, linux-sunxi <linux-sunxi@googlegroups.com>, devicetree <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Sun, 20 Sep 2015 18:17:34 +0800
X-Original-Message-ID	<CAGb2v65pPzZsb0X5WQ6-X9tEqvNYYGPiLrKxR18+nZ0P4R-VCA@mail.gmail.com>
X-Original-References	<1442372732-27434-1-git-send-email-wens@csie.org> <1442372732-27434-2-git-send-email-wens@csie.org> <20150920041722.GI3039@x1>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1228857

Show key headers only | View raw

Hi Lee,

On Sun, Sep 20, 2015 at 12:17 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Wed, 16 Sep 2015, Chen-Yu Tsai wrote:
>
>> The DC1SW and DC5LDO regulators in the AXP221 are internally chained
>> to DCDC1 and DCDC5, hence the names. The original bindings used the
>> parent regulator names for the supply regulator property. This causes
>> some confusion when we actually use it in the dts:
>>
>>       axp221 {
>>               /* self supplying? */
>>               dcdc1-supply = <&dcdc1>;
>>               dcdc5-supply = <&dcdc5>;
>>
>>               dcdc1: dcdc1 {
>>                       ...
>>               };
>>
>>               dcdc5: dcdc5 {
>>                       ...
>>               };
>>       };
>>
>> Change them to the downstream regulator names, or "dc1sw" and "dc5ldo"
>> respectively.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>>  Documentation/devicetree/bindings/mfd/axp20x.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Applied, thanks.

Mark (in his reply) has a point. If these are internally connect, we
should just remove them from the bindings, and associate them in the
driver.

I'm looking into this. In the mean time, could you drop this one?

Thanks
ChenYu

>> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
>> index 41811223e5be..8e79252b1e7c 100644
>> --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
>> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
>> @@ -60,8 +60,8 @@ DCDC2               : DC-DC buck    : vin2-supply
>>  DCDC3                : DC-DC buck    : vin3-supply
>>  DCDC4                : DC-DC buck    : vin4-supply
>>  DCDC5                : DC-DC buck    : vin5-supply
>> -DC1SW                : On/Off Switch : dcdc1-supply          : DCDC1 secondary output
>> -DC5LDO               : LDO           : dcdc5-supply          : input from DCDC5
>> +DC1SW                : On/Off Switch : dc1sw-supply          : DCDC1 secondary output
>> +DC5LDO               : LDO           : dc5ldo-supply         : input from DCDC5
>>  ALDO1                : LDO           : aldoin-supply         : shared supply
>>  ALDO2                : LDO           : aldoin-supply         : shared supply
>>  ALDO3                : LDO           : aldoin-supply         : shared supply
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] regulators: axp20x: Rename AXP221 DC1SW and DC5LDO supply names Chen-Yu Tsai <wens@csie.org> - 2015-09-16 05:10 +0200
  [PATCH 2/3] regulators: axp20x: Rename supply names for AXP221 DC1SW and DC5LDO Chen-Yu Tsai <wens@csie.org> - 2015-09-16 05:10 +0200
    Re: [PATCH 2/3] regulators: axp20x: Rename supply names for AXP221  DC1SW and DC5LDO Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-16 12:10 +0200
  [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW and DC5LDO regulators Chen-Yu Tsai <wens@csie.org> - 2015-09-16 05:10 +0200
    Re: [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW  and DC5LDO regulators Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-16 12:10 +0200
    Re: [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW  and DC5LDO regulators Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
    Re: [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW  and DC5LDO regulators Lee Jones <lee.jones@linaro.org> - 2015-09-20 06:20 +0200
      Re: [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW and  DC5LDO regulators Chen-Yu Tsai <wens@csie.org> - 2015-09-20 12:20 +0200

csiph-web