Re: [PATCH v1 1/2] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 1/2] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP
Date	Sun, 20 Sep 2015 06:20:02 +0200
Message-ID	<qaEgy-5MM-33@gated-at.bofh.it> (permalink)
References	<q8xsT-Tg-25@gated-at.bofh.it> <q8xsT-Tg-23@gated-at.bofh.it>
X-Original-To	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=MHDaGNX3VJmDMN69/bNdlZqax8mYHYfJotTFXncQvJ0=; b=RWeQikl1k7Z3Byh+BGpot8Kv9uh431GCpz/v8JqRtLQraq7sv1ZfwBPkLvs4HTpLGS 1BIQuAhPTPpfRmpuePB2W8p9HHw93tJC0CKDaKd8zUAJCeHAKbG8pOXfKUsyi3WIaty6 S2Dt8fzgyamKbq6mYVAywF1SRjjd89+RzF7EZDe3gpYZVTSvhxpFwnYbZXZjHIl45GYt 0aX+Sve4fF9r+am1ghUBwYVHMZRZaxiPdtq//j4/1qXW735Ke1h9UmIlplGYekhjeYtw LVPjz/pmrOIoOzFE269vMP+r5snGP59CHh04Cw0+FGoUDZixvCcpL22BF0dFXTCq0zvP qzXQ==
X-Gm-Message-State	ALoCoQln/C8NoHILsbrOtSGpgL/zabl3sOuUT5WN9kDzgKxYituCYuoAtVw0chDmcwDQvKuh8vFC
X-Received	by 10.68.248.102 with SMTP id yl6mr16863542pbc.66.1442722571883; Sat, 19 Sep 2015 21:16:11 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Mika Westerberg <mika.westerberg@linux.intel.com>
X-Original-Date	Sun, 20 Sep 2015 05:16:01 +0100
X-Original-Message-ID	<20150920041601.GC3039@x1>
X-Original-References	<1442219568-14725-1-git-send-email-andriy.shevchenko@linux.intel.com> <1442219568-14725-2-git-send-email-andriy.shevchenko@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1228828

Show key headers only | View raw

On Mon, 14 Sep 2015, Andy Shevchenko wrote:

> Jim Davis reported the compilation error with a random configuration which
> apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that conditions we have
> missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.
> 
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mfd/intel-lpss.h | 2 ++
>  1 file changed, 2 insertions(+)

Applied for -fixes.

> diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
> index f28cb28a..2c7f8d7 100644
> --- a/drivers/mfd/intel-lpss.h
> +++ b/drivers/mfd/intel-lpss.h
> @@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
>  	.thaw = intel_lpss_resume,		\
>  	.poweroff = intel_lpss_suspend,		\
>  	.restore = intel_lpss_resume,
> +#else
> +#define INTEL_LPSS_SLEEP_PM_OPS
>  #endif
>  
>  #define INTEL_LPSS_RUNTIME_PM_OPS		\

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 1/2] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-14 10:40 +0200
  Re: [PATCH v1 1/2] mfd: intel-lpss: fix build error when  !CONFIG_PM_SLEEP Lee Jones <lee.jones@linaro.org> - 2015-09-20 06:20 +0200

csiph-web