Re: [PATCH v5 07/23] regulator: core: Remove regulator_list

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 07/23] regulator: core: Remove regulator_list
Date	Sun, 20 Sep 2015 02:40:02 +0200
Message-ID	<qaAPE-JA-9@gated-at.bofh.it> (permalink)
References	<q9GX8-40N-3@gated-at.bofh.it> <q9GXa-40N-33@gated-at.bofh.it>
X-Original-To	Tomeu Vizoso <tomeu.vizoso@collabora.com>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="55BQxs/tzKPczcTk"
Content-Disposition	inline
X-Cookie	You are fairminded, just and loving.
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	209.49.225.226
X-Sa-Exim-Mail-From	broonie@sirena.org.uk
X-Sa-Exim-Version	4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned	Yes (on mezzanine.sirena.org.uk)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Stephen Warren <swarren@wwwdotorg.org>, Javier Martinez Canillas <javier@osg.samsung.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thierry Reding <thierry.reding@gmail.com>, Alan Stern <stern@rowland.harvard.edu>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-arm-kernel@lists.infradead.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>, devicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, linux-acpi@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
X-Original-Date	Sat, 19 Sep 2015 08:01:29 -0700
X-Original-Message-ID	<20150919150129.GR12027@sirena.org.uk>
X-Original-References	<1442494637-3674-1-git-send-email-tomeu.vizoso@collabora.com> <1442494637-3674-8-git-send-email-tomeu.vizoso@collabora.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1228795

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Sep 17, 2015 at 02:57:01PM +0200, Tomeu Vizoso wrote:
> As we are already registering a device with regulator_class for each
> regulator device, regulator_list is redundant and can be replaced with
> calls to class_find_device() and class_for_each_device().

This appears to leak references to the struct devices returned by
class_find_device() - it takes a reference before it returns so any
device found using class_find_device() needs to be released with
put_device() and I don't see any new put_device() calls in here.

> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None

This is not the case at all, this patch was newly added.  If you want
to include changelogs like this in the patch description try to ensure
that they bear some relationship to reality, if they don't they are
actively harmful as they are likely to mislead or annoy the reader.

Thread

[PATCH v5 0/23] On-demand device probing Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:00 +0200
  [PATCH v5 19/23] dma: of: Probe DMA controllers on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:00 +0200
  [PATCH v5 07/23] regulator: core: Remove regulator_list Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:00 +0200
    Re: [PATCH v5 07/23] regulator: core: Remove regulator_list Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
      Re: [PATCH v5 07/23] regulator: core: Remove regulator_list Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-20 22:40 +0200
        Re: [PATCH v5 07/23] regulator: core: Remove regulator_list Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-21 16:10 +0200
      Re: [PATCH v5 07/23] regulator: core: Remove regulator_list Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-21 16:10 +0200
  [PATCH v5 21/23] driver core: Allow deferring probes until late init Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:00 +0200
  [PATCH v5 17/23] pinctrl: Probe pinctrl devices on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:00 +0200
  [PATCH v5 20/23] power-supply: Probe power supplies on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:00 +0200
  [PATCH v5 12/23] i2c: core: Probe i2c adapters and devices on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:00 +0200
  [PATCH v5 15/23] usb: phy: Probe phy devices on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 05/23] gpio: Probe GPIO drivers on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 13/23] pwm: Probe PWM chip devices on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 10/23] drm: Probe panels on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 06/23] gpio: Probe pinctrl devices on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 18/23] phy: core: Probe phy providers on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 16/23] clk: Probe clk providers on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 08/23] regulator: core: Drop redundant locking Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 14/23] backlight: Probe backlight devices on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 02/23] ARM: amba: Move reading of periphid to pre_probe() Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 04/23] of: add function to allow probing a device from a OF node Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200
  [PATCH v5 11/23] drm/tegra: Probe dpaux devices on demand Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2015-09-17 15:10 +0200

csiph-web