[PATCH 3/3] regmap: debugfs: Remove scratch buffer for register length calculation

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] regmap: debugfs: Remove scratch buffer for register length calculation
Date	Sun, 20 Sep 2015 02:40:02 +0200
Message-ID	<qaAPE-JA-3@gated-at.bofh.it> (permalink)
References	<qaAPE-JA-1@gated-at.bofh.it>
X-Original-To	Rasmus Villemoes <linux@rasmusvillemoes.dk>
X-Mailer	git-send-email 2.5.0
X-Sa-Exim-Connect-IP	209.49.225.226
X-Sa-Exim-Mail-From	broonie@sirena.org.uk
X-Sa-Exim-Version	4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned	Yes (on mezzanine.sirena.org.uk)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
X-Original-Date	Sat, 19 Sep 2015 07:37:51 -0700
X-Original-Message-ID	<1442673471-26849-3-git-send-email-broonie@kernel.org>
X-Original-References	<1442673471-26849-1-git-send-email-broonie@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1228791

Show key headers only | View raw

Now we no longer use the scratch buffer for register length calculation
there is no need for callers to supply one.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/base/regmap/regmap-debugfs.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index 4c55cfb..4a47378 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -30,7 +30,7 @@ static LIST_HEAD(regmap_debugfs_early_list);
 static DEFINE_MUTEX(regmap_debugfs_early_lock);
 
 /* Calculate the length of a fixed format  */
-static size_t regmap_calc_reg_len(int max_val, char *buf, size_t buf_size)
+static size_t regmap_calc_reg_len(int max_val)
 {
 	return snprintf(NULL, 0, "%x", max_val);
 }
@@ -173,8 +173,7 @@ static inline void regmap_calc_tot_len(struct regmap *map,
 {
 	/* Calculate the length of a fixed format  */
 	if (!map->debugfs_tot_len) {
-		map->debugfs_reg_len = regmap_calc_reg_len(map->max_register,
-							   buf, count);
+		map->debugfs_reg_len = regmap_calc_reg_len(map->max_register),
 		map->debugfs_val_len = 2 * map->format.val_bytes;
 		map->debugfs_tot_len = map->debugfs_reg_len +
 			map->debugfs_val_len + 3;      /* : \n */
@@ -420,7 +419,7 @@ static ssize_t regmap_access_read_file(struct file *file,
 		return -ENOMEM;
 
 	/* Calculate the length of a fixed format  */
-	reg_len = regmap_calc_reg_len(map->max_register, buf, count);
+	reg_len = regmap_calc_reg_len(map->max_register);
 	tot_len = reg_len + 10; /* ': R W V P\n' */
 
 	for (i = 0; i <= map->max_register; i += map->reg_stride) {
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/3] regmap: debugfs: Ensure we don't underflow when printing access masks Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
  [PATCH 3/3] regmap: debugfs: Remove scratch buffer for register length calculation Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
  [PATCH 2/3] regmap: debugfs: Don't bother actually printing when calculating max length Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200

csiph-web