Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228793

Re: spi-imx: wait_for_completion should timeout even in non-DMA transfer cases

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Sep 18, 2015 at 02:38:27PM +0200, Jean-Michel Hautbois wrote:
> Hi,
> 
> I am wondering why in spi-imx the spi_imx_pio_transfer() function is
> calling wait_for_completion() and not wait_for_completion_timeout() as
> in the spi_imx_dma_transfer() one.
> I can't see a good reason for this, maybe should it be calculated
> based on the spi clock and transfer->len, or at least be the same as
> IMX_DMA_TIMEOUT which is 3 seconds ?
> If you want it, I have a patch, just tell me if you are interested and
> if you prefer a calculated timeout or even something else ?

A calculated timeout is probably best.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

spi-imx: wait_for_completion should timeout even in non-DMA transfer cases Jean-Michel Hautbois <jean-michel.hautbois@veo-labs.com> - 2015-09-18 14:40 +0200
  Re: spi-imx: wait_for_completion should timeout even in non-DMA  transfer cases Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
    Re: spi-imx: wait_for_completion should timeout even in non-DMA  transfer cases Jean-Michel Hautbois <jean-michel.hautbois@veo-labs.com> - 2015-09-21 11:10 +0200

csiph-web